From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A799FC7EE23 for ; Sun, 4 Jun 2023 17:22:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232203AbjFDRT5 (ORCPT ); Sun, 4 Jun 2023 13:19:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbjFDRTz (ORCPT ); Sun, 4 Jun 2023 13:19:55 -0400 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 402A7D3 for ; Sun, 4 Jun 2023 10:19:48 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 5E3FD320090B; Sun, 4 Jun 2023 13:19:44 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Sun, 04 Jun 2023 13:19:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1685899183; x=1685985583; bh=wS OEKEurWAF+VcZsiiHB+3LhvZ5bUw8O1z/roOZuKHE=; b=dqtTpx6+WgkKZ8Jima 8A5b48rRsD/cTDKekar08ZRznEP6n1GwtVDfWPG0Ycv+6rx3XI10v4+U0VyY9Uu9 DZ/UJqtqh/uvsFjnUk11H4Y3IQDNp1ClbwekHHgSHmjG9f6uXH119Jz6BMMPUV3S 3AwrAWT/slmwsd2PRU0E0hJEyIcd101DcNmK2lP81cDFQ73dflSVlFWrO1VOjeFk 2Qlgo9o52GZBTU4K2ul6PAUxVBLbuQQqjWhXhbqTcx3VCyzNH3Qf+loaarJbgPix zMbJq7gjEZJCSj9FH6nAzULtxeEX8RTdLhB5WrTLduTdX6bQCEDNPjTQT0Gr/NkX HPcA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1685899183; x=1685985583; bh=wSOEKEurWAF+V cZsiiHB+3LhvZ5bUw8O1z/roOZuKHE=; b=ddeGSA5R5RmWO8z19FXXzrDZ10iXG PI6IdRcU6nCMWLa0kLaUF/Ol2Ty+qNpSY14+mqphu0pah87TXt+nYp9G6VWn7tuP JRt6eLyIvoFmkhD5tarjcEM0T0/SMxD+/maVX0dyBIodxAlKs3mvay0ZbY65G+YY vuMWnOMfTL7ayey349+/gVUvhkaMiCReV654avuztH2n7vGb4p5lsENV14Sq5ogl FulL0QtV7LU3h0zk+C0vRjTzkSOB05zF1htwxIFZIk4TTTxjLF0WJhOOEoydcAJH 53CxCVb/QTZ1CYdEalSOY4DGQfEUf4FMkXSjHF7q0ilpriE7YVL6Y0Ibg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeljedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 3189BB60086; Sun, 4 Jun 2023 13:19:43 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-447-ge2460e13b3-fm-20230525.001-ge2460e13 Mime-Version: 1.0 Message-Id: <44c969a1-8dda-425b-acf3-9a80dfa60e79@app.fastmail.com> In-Reply-To: References: <20230424123522.18302-1-nikita.shubin@maquefel.me> <20230601053546.9574-10-nikita.shubin@maquefel.me> Date: Sun, 04 Jun 2023 19:19:22 +0200 From: "Arnd Bergmann" To: "Andy Shevchenko" , "Nikita Shubin" Cc: "Alexander Sverdlin" , "Linus Walleij" , "Daniel Lezcano" , "Thomas Gleixner" , "Michael Peters" , "Kris Bahnsen" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 09/43] clocksource: ep93xx: Add driver for Cirrus Logic EP93xx Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 3, 2023, at 22:06, andy.shevchenko@gmail.com wrote: > Thu, Jun 01, 2023 at 08:34:00AM +0300, Nikita Shubin kirjoitti: >> This us a rewrite of EP93xx timer driver in >> arch/arm/mach-ep93xx/timer-ep93xx.c trying to do everything >> the device tree way: >> >> - Make every IO-access relative to a base address and dynamic >> so we can do a dynamic ioremap and get going. >> - Find register range and interrupt from the device tree. > > ... > >> +config EP93XX_TIMER >> + bool "Cirrus Logic ep93xx timer driver" if COMPILE_TEST > > This is strange. What do you gain with this "if COMPILE_TEST"? This ensures the driver is compiled in an x86 allmodconfig, like most other clocksource drivers, but it's hidden on all other configs without EP93xx support. As long as the platform selects it, this is the normal way to add a clocksource driver. Arnd