From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965194AbdAIKub (ORCPT ); Mon, 9 Jan 2017 05:50:31 -0500 Received: from mail-co1nam03on0053.outbound.protection.outlook.com ([104.47.40.53]:17920 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965023AbdAIKst (ORCPT ); Mon, 9 Jan 2017 05:48:49 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH V6 2/7] perf/amd/iommu: Modify functions to query max banks and counters To: Joerg Roedel References: <1482500330-5606-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1482500330-5606-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20170104144853.GE10632@8bytes.org> CC: , , , , From: Suravee Suthikulpanit Message-ID: <44d807c7-35e2-006d-ed82-ec367a817239@amd.com> Date: Mon, 9 Jan 2017 17:48:27 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170104144853.GE10632@8bytes.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [114.109.128.54] X-ClientProxiedBy: SG2PR01CA0021.apcprd01.prod.exchangelabs.com (10.165.9.159) To CY4PR12MB1447.namprd12.prod.outlook.com (10.172.71.139) X-MS-Office365-Filtering-Correlation-Id: 4a0ed523-1f11-4887-2e8f-08d4387d1684 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR12MB1447; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1447;3:KTy8tzVtGzQ0g7plTbI1IqWBvoXW2ZwqVcJxubMvYTQpTWPD9KlmOWwrw6QrhD51HtnkP1eUjdN8gC5+auwHhtFJcWmkbzDU5CS0WXiy7TGa0rxCWb4aClk5nGMzbsCnRgpsAckeAox7F2kv5oJILLFmfcqYXeYCO1A5vcQ7vvAuOqsAVZ1+jkz28S7TKEhLw9Q/xpVvqrkp/PTrDV14jz97IVSiQDi0/vdseqjW+Zj3/BONGCEnftuis41xnAomCQ9B2OtjEIzoXFzVvZU53w==;25:Q8bImXY4oAwXnoLBlUfAWF4njNQI/zZSlv1T7+ZaWR9pNG8NCyALZrnYJauprWwqVr142Sok5uiQEyaU+Y0Xp29Me+pnxzy08A1Tl9baOK+H/sfAL4rlyYIgc+FWeQdXZBNgL7E1hdQuNn63rPhL+Fc4Qx+TwYHYoBuDbeDn+kvrl4HgHHjiwVXbutASY5Mp20lBmkMDYEIakT0EHAldDOx0zjXQ9AO/zGN8cKRoupJJ+17maGsbvPdY9h+K9xbgox3VEFGkTG7WvK4J1RaShl2jR0Hmfd16VT5aLT3EGdkIwAvcRhiLdn0dJKxd8AB4sOXF7eqTksKVSDnczqFMLaqMDtOrV0AL2DJAVhvMimQIf4skcnZyHe9uhiJVBFnYS0IN+FukpRjzckQoKa5cqxKOkJeVo1KCsWSyTqOxHn4k82u1Z43LgiQZyW2koxmJCtVqrKAXOBhEbJfqZJAXUw== X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1447;31:fgDr+/8MV4nc0ivXRAxbJfn4cMEPoV4YGO6YKCO50gKkCLtvQaSrX9JCKwI6XePRjNazNlpY8mxH1uPUqiR1IiVn3fSXHI5zVoKj79op/MVTZcXrFh/vl7bwJsZtqw7ba9ZjSE65EVuCJRkna2HapzkCMlU3L7L6B3QyRZ/XyU+458YfBhOftWL4784JcEqvHBHyH3kt1ElZffNTwmNR4e0DdW8f3SFPs8/wYeA8Q7+jai3SrNmNVuaQ/bQLveG+hQEvhBSOtYuymH6fPZmhqwLVvgkyC2PFryygVv5x83I=;20:+S2XfDL8ra2QxJbPtY4mt4XW9onPnbv4BMq9NC1RxdLG9cjaGa8rtWdWiBA3KJ4BCXsifiAH0yQzKahd6Q96IZLarldvS3asIts1l7fqLtzOt9KMHCAG7LxZjsqMGrfBg2feDBBhXNbLuwGGVm12d6ZU0H88drmAAetB9ABAiqvJWehcAdv1hC9surzb+n0CvPO7lJ7Kx58AYr0hSka551xYaI9lkpSoHtQLYosYgx4lTwcqYF0UqGi6QHQXuAGn2eODh9gj+w9WsZFtirgGfDBAwWAiGV/v9tEa1yZZZgmJ2Lu2ZFyMv2uPuIaJCkyP4ZKx69I168UHaxbmK8VcPGgMmdB7UljagW1K3xHuh1uBrroePwH0zS/cibz/SimjDn4u/n+RHss0eK+WYz/Kma6oG0DIabN5ij15R5K+90keA3L7wlNf94B288F8QbRoMXt+SrTYuPSnu5pTe72LasuDV8EvBqhrqs51g6ubYMG0tpR8/iShIrFcjNmgsOG7 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123560025)(20161123558021)(20161123555025)(20161123562025)(20161123564025)(6072148);SRVR:CY4PR12MB1447;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1447; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1447;4:uNI422aXF+4TblRzBZTKLWstYXeJy07iig9gdWon9dqh/EYdjk83/W3NBr05XytPB9TTUv+6gmo7JhuV3BBL2aYqYRGhFnlseNyxyPQz9uwUgNare1mbtBN49akonKnmwMgKrH6e27viIznh/Kqd0VsJBFSTf3/ORJOG5+N5qard/8AOZ7MMVv2oLR00Dib0UkIAVij/g4bQw9OYMCjQF2cmDHF0XzeYx0Ia2WjF3bI03GRJu8PPSqPuq0XSnL+4O6OVAzJbRQv/L0aKmyx+Qarkvg+sKB1gxTrDdtcSYblo8nb02q1yloj4mfQtQPMRw7evPBdn0QdoPnQN8uOaKSyGIBZVHCRvV4PRdze9SWB9232RdusiQlsFx1yWXGdVKmJvoFE2z6HMQN/83nCLyj/JeJ+XkoCKdI+Yy9u/DMSYYbfP6QnQsMFbf2PCTJXdpbWwGX2eTxmjN2k+EjvNKTz1B+YSg7UfYlLk1flFk96kxcxOJfD+uRKVtoaBGN1DNJhuBM/RQmunCYFK00uDhNavkQ1ZG3osevuH3xoJibtdt+gWvXvR0AsGB4QRQrlJK1l+N/G3arT3UvR+UukxgcObaOKVc2GQ43b4xV16ceXVcgrwFnbeoLomkS0f38+j X-Forefront-PRVS: 0182DBBB05 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39860400002)(39450400003)(39840400002)(39410400002)(39850400002)(24454002)(189002)(199003)(50986999)(76176999)(110136003)(2950100002)(2906002)(54356999)(31686004)(42186005)(65956001)(65806001)(101416001)(92566002)(6116002)(3846002)(66066001)(47776003)(105586002)(106356001)(4326007)(230700001)(8676002)(81166006)(23746002)(81156014)(36756003)(305945005)(31696002)(33646002)(25786008)(50466002)(64126003)(7736002)(189998001)(38730400001)(54906002)(6486002)(229853002)(86362001)(6666003)(68736007)(65826007)(5660300001)(6512007)(6916009)(6506006)(97736004)(83506001)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1447;H:Suravees-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR12MB1447;23:u9V6j4csPODfih7b5om9Qwye1cZLrXNedvUDA?= =?Windows-1252?Q?8i6Zb+4GUekGZp0NOoQmbJA0VCseTj6Al8ndlTQSzoUQsjyPx3c5l7cl?= =?Windows-1252?Q?zRfvzfGomP9509l2bdWuiEkHT156xihzkyS8M8uND444yV5nRUwnNdwa?= =?Windows-1252?Q?zzw3tJPqSZSSb3e+6cMwajVr0By+v8PD7eSOGvGJMRydaiIpL4HoiyvS?= =?Windows-1252?Q?/dhY72QXGNbV4bBYDABnbe+8nbs/SgYvJluv1GrXAbA6maPmL3EIaknm?= =?Windows-1252?Q?aykwHUzv9B84Gq6n2n4rccjR6kWR8s7qS04VAQLCG8KGubTPFRUIm6tH?= =?Windows-1252?Q?Na3ePRMcrnZGVod0RcMxbtVvKw32VMBZX68i9aT5S29XdG95xGdP8a1V?= =?Windows-1252?Q?8OfZWU+doDFlQ8ZDiXZMXk4fm5M6QNLbKx1JaWjt6A9EMWzI2asyGiTY?= =?Windows-1252?Q?ClZb7pR7mywMBiU1YaM1vHiCuyaLVz0f551yu3XZHuW+ylhTrncJmLOa?= =?Windows-1252?Q?ArVeZ/7sD5CyUstMGD2Gz8syt7PFtz46qsj858sUl/CnuGyKpuS8eaA1?= =?Windows-1252?Q?YrQVzvvMdjJs2U3jOOErlwQLdpzA160jthTKTy0wqSCslfPL8FHcceZm?= =?Windows-1252?Q?kf5h2n85YwDv2uo119Ca+GwFSp7EN8Buu1qLmIbjuj/alYKLLKnIX/8Q?= =?Windows-1252?Q?Xy84Ghn3yScr+4xOYzF+hgjtms7eq++akrQMYMGlqBzWjJ2QtAGTxQId?= =?Windows-1252?Q?d9NH291oUykQqCdmSMNfGHoaY7FnWOM8Kh5JZTD8smq/8lqo2aeYeO6o?= =?Windows-1252?Q?n6SpxQnXmKs5npOCJ7L+2Ouswu2R1OV3E8fGo3B48o7FznjDGbU9gI85?= =?Windows-1252?Q?IrcVmCCQFNc9/LpYr2GSMt6gVG3s/qCuVP/ZxJfdrstDqhMWrp47576r?= =?Windows-1252?Q?4KXo4m0Uh4AqldlEOGAPi0/kPZDxpBWyFyAGyUrtod6w5KNt+6imz8hR?= =?Windows-1252?Q?eoPF82IP9iX6DNGStuc46DeFbJeh//ohCpUEbdQebSkozZVvn6FqnMbX?= =?Windows-1252?Q?pnNdxuEL6G4gc+tgpE9ESn8MdXcDVhJQEZzTwTl2SD4m033hAWkPBltH?= =?Windows-1252?Q?iD95HdANkt9VJaWZM0A1WH+YUZz1Pz85aZ88BCEpZGG0ivA0kqSKOkem?= =?Windows-1252?Q?nEqMzK8prjCmGvoAt9sWULIsNSqAjuH7NM5I7MIJEuTFEP5Y9S/ELkRu?= =?Windows-1252?Q?r98wLcUb2BilR+gXAr42Px03iHBVeCoqtKgCXLimYd374TdbAiTb6/R4?= =?Windows-1252?Q?7ye3Rf0/OlmFYyl03B0pqdenK4X4ctcAm6rYluht5ZPIw7oTfHLpnotD?= =?Windows-1252?Q?Nqkz1bNh3aSeGxraZg6F4mPEZ7x8WU8Vew9e0qnGQsu6Pzt1AxHcmw0n?= =?Windows-1252?Q?2qk7oXNyNOU5d5f4dHUAV33zieFN8KoXzv0n9Z/axXBBa8XbrLsVakRw?= =?Windows-1252?Q?SCin7v/eAPReMfCB7E5mVx1pnokThJ9SCpUv+rXAEVSgEGNPw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1447;6:JXHyTc3yOAngoID4XcDhfbJGYZvXNPx4vHwfvbLdsja3FV33axyhWIpre6NTFqeAYTCDy/vCAGs/FLXdOoRVLCKbTuW/+FeONe/s6jr/slF52u/gPzQT/X70ljtXKvvNk/VafTNrwRyi+3sxZV08vyguGeAXs/JaEt4HMu+pG71TG0aq/fv4qrA743ABIOjVHTYMBnn6AOdpIV3S00cvqQCM65qKdCa9CHrpO5RIjFQudFjm6GpyRMnkLYIo4A3Ghysx+EhpaKUTKnLPOdVGLConeLCXjPNM2TgRrmSv/GOEdl/1gMKFf7w76wsLJWzzEPJIFpW/LmfKsjPtsjYOBZW2AIkFoh2Qj8T4FICQSQ6BC+XUo++B9elsb7v4Jg77/Qm15Deu6o3RJyLbRWFTW103EBnMt3Mh0pb//aSJiUePG2R5Zybw9wwa+WvbiOfxqxkAnmQNo7MrYgFtuTQvZA==;5:6UavkaDLCnvUHS3WC3W05zOqIJ9NKeS8yymC4W3IWCMfah6OxwLcf9VeALb90RBjo2fgGBVxvIr6svPLlF4NX0/abLaB1PwdZgjpjjp25HHRzr7L0CSaQuBUDn2EAWeIQos0w54cBAdSpY8nYxljaw==;24:ySN7e/HrTTQ6wKUYkHmUveN747BCYM5xlW9GSc2hwdV2+mkDCbWrnvttvNJkPxhXH68xCilep55WBwyxoQZG6Af+MqZfhxg+u8BrKi8zrDI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1447;7:Ir14C+Yyu7/1MzUwKBkLftDQKbcy8Lhvf3NO0zYPpiwRuMiK3ow8SWVgG8bBN6TW7MYK1qIOvKMbhbxe7xr2FZRsyCpkrVGNsPgFKX9nwdIHlg5GIm2jHwSlxDyRA5rTDMpB1m0gvlZag1QnxQ6wtV9b3izCkJb3MDbFEKNs2UAIO0m3tqUsqB2tIwmusMiQGllz1Q2f5cpXaoiIvUiR89gb7VIT2jyRrAdamI3IbYszPJZPVG9DzvWgQ3HIzGs9RZRf5/zVsgqLfl/oj39yiOTsvlIe3aq/Z0PdjYx77aks3mYjDTKZN12yAoEPfqJr9bAOVPrl2CDC87PFCnVsyBfZl9CgLTSBbVo2fCCEzWonQFqvV/U24eIwk/cvCPXx1ifirfnfLMAp8UWJq9gpMLPoqZ80sw2LAEivWw512JDf1ig+AECFJcS7hHeBbC0sjIWQvUG3bvM986UhroduFw==;20:2MfO1nHCH11KjeHlt95LC5kCXtHpVZviipHUe738TsjM8kwtY85swim0AiQURbHEuSVNNKXGkhRFqlb8PceLsBtiX8l/jGO8MEiD1Fi3U7r4zMazUZG5hTGMmf03UVKfuLtQeJp7Y4rvrvcYUcPr3jtDZeup4ouv+HfEJcJZptnl2aoZBGmxdEJbOewZtEvLo9T6m2bV9FnT3UQ0ot2ZXWNZxtW/H1ujaHBYfIZ+7Nw0c3X5bV8GWBKNwryib+6M X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2017 10:48:44.6274 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1447 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/4/17 21:48, Joerg Roedel wrote: > On Fri, Dec 23, 2016 at 08:38:45PM +0700, Suravee Suthikulpanit wrote: >> --- a/arch/x86/events/amd/iommu.h >> +++ b/arch/x86/events/amd/iommu.h >> @@ -24,15 +24,12 @@ >> #define PC_MAX_SPEC_BNKS 64 >> #define PC_MAX_SPEC_CNTRS 16 >> >> -/* iommu pc reg masks*/ >> -#define IOMMU_BASE_DEVID 0x0000 >> - >> /* amd_iommu_init.c external support functions */ >> extern bool amd_iommu_pc_supported(void); >> >> -extern u8 amd_iommu_pc_get_max_banks(u16 devid); >> +extern u8 amd_iommu_pc_get_max_banks(uint devid); >> >> -extern u8 amd_iommu_pc_get_max_counters(u16 devid); >> +extern u8 amd_iommu_pc_get_max_counters(uint devid); > > The parameters are now iommu-indexes and not device-ids anymore. You > should reflect that in the prototypes here too. Ahh.. thanks for pointing out. I missed this part. >> diff --git a/drivers/iommu/amd_iommu_proto.h b/drivers/iommu/amd_iommu_proto.h >> index 7eb60c1..1f10b3f 100644 >> --- a/drivers/iommu/amd_iommu_proto.h >> +++ b/drivers/iommu/amd_iommu_proto.h >> @@ -58,8 +58,8 @@ extern int amd_iommu_domain_set_gcr3(struct iommu_domain *dom, int pasid, >> >> /* IOMMU Performance Counter functions */ >> extern bool amd_iommu_pc_supported(void); >> -extern u8 amd_iommu_pc_get_max_banks(u16 devid); >> -extern u8 amd_iommu_pc_get_max_counters(u16 devid); >> +extern u8 amd_iommu_pc_get_max_banks(uint devid); >> +extern u8 amd_iommu_pc_get_max_counters(uint devid); > > Same here, and why do you need to declare the prototypes in two > different header files? Hm.. actually good point. I will remove the unnecessary function declarations in the amd_iommu_proto.h. Thanks, Suravee