From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751362AbdE3SFa (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 14:05:30 -0400
Received: from mail-pf0-f196.google.com ([209.85.192.196]:35426 "EHLO
        mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751032AbdE3SF3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 14:05:29 -0400
Subject: Re: [PATCH 2/2] net: phy: micrel: Restore led_mode and clk_sel on
 resume
To: Leonard Crestez <leonard.crestez@nxp.com>,
        Shawn Guo <shawnguo@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        Andy Duan <fugang.duan@nxp.com>
Cc: Johan Hovold <johan@kernel.org>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Fabio Estevam <fabio.estevam@nxp.com>, netdev@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <cover.1496164448.git.leonard.crestez@nxp.com>
 <a8d0393c977b0d6fdab5d48ad13ca4d1ca893a07.1496164448.git.leonard.crestez@nxp.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <44ddeaeb-3e23-3d88-cc5c-9ed290507648@gmail.com>
Date: Tue, 30 May 2017 11:05:19 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <a8d0393c977b0d6fdab5d48ad13ca4d1ca893a07.1496164448.git.leonard.crestez@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/30/2017 10:34 AM, Leonard Crestez wrote:
> These bits seem to be lost after a suspend/resume cycle so just set them
> again.
> 
> This patch fixes ethernet suspend/resume on imx6ul-14x14-evk boards.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
>  drivers/net/phy/micrel.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 6a5fd18..c53ee17 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -700,6 +700,9 @@ static int kszphy_suspend(struct phy_device *phydev)
>  
>  static int kszphy_resume(struct phy_device *phydev)
>  {
> +	struct kszphy_priv *priv = phydev->priv;
> +	int ret;
> +
>  	genphy_resume(phydev);
>  
>  	/* Enable PHY Interrupts */
> @@ -709,6 +712,18 @@ static int kszphy_resume(struct phy_device *phydev)
>  			phydev->drv->config_intr(phydev);
>  	}
>  
> +	if (priv->rmii_ref_clk_sel) {
> +		ret = kszphy_rmii_clk_sel(phydev, priv->rmii_ref_clk_sel_val);
> +		if (ret) {
> +			phydev_err(phydev,
> +				   "failed to set rmii reference clock\n");
> +			return ret;
> +		}
> +	}
> +
> +	if (priv->led_mode >= 0)
> +		kszphy_setup_led(phydev, priv->type->led_mode_reg, priv->led_mode);

Should not we actually call kszphy_config_init() in order to restore
broadcast and nand disable bits as well?

If not, I would be more comfortable if we did create a specific function
that takes care of setting the reference clock and LED mode.

Other than that, LGTM!
-- 
Florian