From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 077BF376E0 for ; Mon, 23 Dec 2024 10:43:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734950586; cv=none; b=Sm7WRkSi41pWfyT6KnIOck8REK18AGqlE5L39K+dibv+nSG8bLqeoRURNplZ5dX/DX55mQM960nHLPW0kE/uyFEEtfGxVNNz59Pl63WC5/GbuGVYDRZR2LOHHM03O4uBT5bdUgYOPtwE66JBUVN1NxWJHlQv6bwOd/g11oxfP1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734950586; c=relaxed/simple; bh=YkmBrxIAUTdUOfoVhMpJzYCpjrVjAZNEn3V4SevKeSQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fMXu97x7WDomCYn6aXCPaf/1eLZqJ9GeNy1v6RYxwsL22B4e7pwir5OOEqTsBNPZ/uU5csnD2o3tz3nnsL08KZb3w029LuQBcSzTGASMrq7kWmXGxkWWPoiGVZ2gwlr35MH2nDvfj2Js8RnkUO2wJPNfSseXkMzEovhmf32qDoo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RkzDEzj+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RkzDEzj+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734950582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SrE4s6q6jCgjFeNMs+7CNRqUsXg3iyoubivFdrIuNY0=; b=RkzDEzj+hg+nItXReLoxSrP59+QiodvDURChJS+0Va1NsjSswTf2Kjp84/sShXE5bkXdSV R9H4NzkRoh0T4rKX80DH6fprOed27PElQTLCRqwpBQc6qKJMQJkHLwcVlnKuOCjQLDxHbD Gge6vEMXvLKWRqycCRKJp9bp49v9nNE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-IxWdLybGMAqBaCtn928NKQ-1; Mon, 23 Dec 2024 05:43:00 -0500 X-MC-Unique: IxWdLybGMAqBaCtn928NKQ-1 X-Mimecast-MFC-AGG-ID: IxWdLybGMAqBaCtn928NKQ Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-385d52591d6so1909853f8f.1 for ; Mon, 23 Dec 2024 02:43:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734950580; x=1735555380; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SrE4s6q6jCgjFeNMs+7CNRqUsXg3iyoubivFdrIuNY0=; b=lKOBpvNuCQvb759NiMH07k8N6K2WtKq8uzM+fTANdX96D2/NJM+v2YddpTqIZZ8siP tKJChBgDp68NiAANUAkeVYCxPzi57QIUvIUVl3eB7etvTLOmB7xM+akGDpy+bs00KEkd xmok3ZJbH9dWBidBNG2Fo66/EarUIo9D9XTjplt7KsE38egooBpc8a2U0gwvyEdYwH6o cYZ+uLoCJr+UAs0CDexhyOrinufLlO9VLY07saCTnsgqLOKZI9M+smIS9jNgU6ZT4Z4a jojLSP8QzEJKTh1ycAiyvjZHkPhn3PTYpK1bDBJbBpg64aPIxjwLnlzuA2l78sbIS2yi wfHA== X-Forwarded-Encrypted: i=1; AJvYcCVyK+qMBQ86WS9jos9NOfdEAu27YGjI0MzyCagbkIXU+9bE7Qatef1d9MUFGX24WL+SFZDRZZEVXyaRn64=@vger.kernel.org X-Gm-Message-State: AOJu0Yypa61FvMVl/iF7IbQUS8jhr/p6ko2E2oW4jxEk8fAX84Ei3wot t4TYDDVMkTubRiBYEExOIPlcfrFqGziVQtFChXx4OX8LosUEj0LKhbllT8LS/AR5lDnfggOIi0F y8ke2kS1KxGwaaD++L4otbwO8uoJF6fQKI93rLyc5aXSyZ3pmQHpW9Urxqtdo3g== X-Gm-Gg: ASbGncsaDQB48wa64mbXsbBfvkXgGOHx7itHPCu9LuITcEUGYDsLuXfYDjSXen395MV kmeP+FwYLA7ySBuMnai8WesW81jUZEiMubxhz4vBtSXBv7D+c0rwY+X67WrcmNWGc3Ssm3Is4Of vgbQUbox1v7/k8MOtIS45CAUgORq649Jvcdf1qX3WvR/e5qwInvEVaiYL9t6MldbFKaXwki1Q3D ciGel7zEiyZN5fNdBOrdojhrYaK5QPqqRrxOBV3mlTN3EL6cF5azYUWnzFbKJvahq/iasV/rzWv O/zOdz0n6ZycLLra+TKXCOI+ok+kWv44moZqed3/xWFaD8SpRM18ssa6rPSO16kUKltlSVjy0aS UdJrZa1m6 X-Received: by 2002:a05:6000:178c:b0:385:f138:97ac with SMTP id ffacd0b85a97d-38a229ed113mr8928732f8f.1.1734950579732; Mon, 23 Dec 2024 02:42:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IEx2bjb/Wnn7lQ/ghqCWT0BKzzLGtJpULkhg/YZXa3QKkzFm/gt4nJwvt+R6aFjgfSsjkTZNQ== X-Received: by 2002:a05:6000:178c:b0:385:f138:97ac with SMTP id ffacd0b85a97d-38a229ed113mr8928718f8f.1.1734950579350; Mon, 23 Dec 2024 02:42:59 -0800 (PST) Received: from ?IPV6:2003:cb:c721:5a00:7b5b:9007:4395:ac65? (p200300cbc7215a007b5b90074395ac65.dip0.t-ipconnect.de. [2003:cb:c721:5a00:7b5b:9007:4395:ac65]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8475d9sm11064252f8f.56.2024.12.23.02.42.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Dec 2024 02:42:58 -0800 (PST) Message-ID: <44de3a6c-6761-4ad6-a4dd-b9002a42c437@redhat.com> Date: Mon, 23 Dec 2024 11:42:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/memory-failure: fix VM_BUG_ON_PAGE(PagePoisoned(page)) when unpoison memory To: Miaohe Lin , akpm@linux-foundation.org, Dan Williams Cc: nao.horiguchi@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241219115209.574065-1-linmiaohe@huawei.com> <06a45f8a-0981-40a2-a12a-5964fcdace13@redhat.com> <1af81f0e-6500-9719-20be-505851673b58@huawei.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1af81f0e-6500-9719-20be-505851673b58@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 23.12.24 03:55, Miaohe Lin wrote: > On 2024/12/20 16:50, David Hildenbrand wrote: >> On 20.12.24 03:35, Miaohe Lin wrote: >>> On 2024/12/19 20:18, David Hildenbrand wrote: >>>> On 19.12.24 12:52, Miaohe Lin wrote: >>>>> When I did memory failure tests recently, below panic occurs: >>>>> >>>>> page dumped because: VM_BUG_ON_PAGE(PagePoisoned(page)) >>>>> kernel BUG at include/linux/page-flags.h:616! >>>>> Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI >>>>> CPU: 3 PID: 720 Comm: bash Not tainted 6.10.0-rc1-00195-g148743902568 #40 >>>>> RIP: 0010:unpoison_memory+0x2f3/0x590 >>>>> RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 >>>>> RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 >>>>> RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 >>>>> RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb >>>>> R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 >>>>> R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe >>>>> FS:  00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 >>>>> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>>> CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 >>>>> Call Trace: >>>>>    >>>>>    unpoison_memory+0x2f3/0x590 >>>>>    simple_attr_write_xsigned.constprop.0.isra.0+0xb3/0x110 >>>>>    debugfs_attr_write+0x42/0x60 >>>>>    full_proxy_write+0x5b/0x80 >>>>>    vfs_write+0xd5/0x540 >>>>>    ksys_write+0x64/0xe0 >>>>>    do_syscall_64+0xb9/0x1d0 >>>>>    entry_SYSCALL_64_after_hwframe+0x77/0x7f >>>>> RIP: 0033:0x7f08f0314887 >>>>> RSP: 002b:00007ffece710078 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 >>>>> RAX: ffffffffffffffda RBX: 0000000000000009 RCX: 00007f08f0314887 >>>>> RDX: 0000000000000009 RSI: 0000564787a30410 RDI: 0000000000000001 >>>>> RBP: 0000564787a30410 R08: 000000000000fefe R09: 000000007fffffff >>>>> R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000009 >>>>> R13: 00007f08f041b780 R14: 00007f08f0417600 R15: 00007f08f0416a00 >>>>>    >>>>> Modules linked in: hwpoison_inject >>>>> ---[ end trace 0000000000000000 ]--- >>>>> RIP: 0010:unpoison_memory+0x2f3/0x590 >>>>> RSP: 0018:ffffa57fc8787d60 EFLAGS: 00000246 >>>>> RAX: 0000000000000037 RBX: 0000000000000009 RCX: ffff9be25fcdc9c8 >>>>> RDX: 0000000000000000 RSI: 0000000000000027 RDI: ffff9be25fcdc9c0 >>>>> RBP: 0000000000300000 R08: ffffffffb4956f88 R09: 0000000000009ffb >>>>> R10: 0000000000000284 R11: ffffffffb4926fa0 R12: ffffe6b00c000000 >>>>> R13: ffff9bdb453dfd00 R14: 0000000000000000 R15: fffffffffffffffe >>>>> FS:  00007f08f04e4740(0000) GS:ffff9be25fcc0000(0000) knlGS:0000000000000000 >>>>> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>>> CR2: 0000564787a30410 CR3: 000000010d4e2000 CR4: 00000000000006f0 >>>>> Kernel panic - not syncing: Fatal exception >>>>> Kernel Offset: 0x31c00000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) >>>>> ---[ end Kernel panic - not syncing: Fatal exception ]--- >>>>> >>>>> The root cause is that unpoison_memory() tries to check the PG_HWPoison >>>>> flags of an uninitialized page. So VM_BUG_ON_PAGE(PagePoisoned(page)) is >>>>> triggered. This can be reproduced by below steps: >>>>> 1.Offline memory block: >>>>>    echo offline > /sys/devices/system/memory/memory12/state >>>>> 2.Get offlined memory pfn: >>>>>    page-types -b n -rlN >>>>> 3.Write pfn to unpoison-pfn >>>>>    echo > /sys/kernel/debug/hwpoison/unpoison-pfn >>>>> >>>>> Signed-off-by: Miaohe Lin >>>>> --- >>>>> v2: Use pfn_to_online_page per David. Thanks. >>>>> --- >>>>>    mm/memory-failure.c | 14 +++++++++++--- >>>>>    1 file changed, 11 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >>>>> index a7b8ccd29b6f..02be0596ce67 100644 >>>>> --- a/mm/memory-failure.c >>>>> +++ b/mm/memory-failure.c >>>>> @@ -2556,10 +2556,18 @@ int unpoison_memory(unsigned long pfn) >>>>>        static DEFINE_RATELIMIT_STATE(unpoison_rs, DEFAULT_RATELIMIT_INTERVAL, >>>>>                        DEFAULT_RATELIMIT_BURST); >>>>>    -    if (!pfn_valid(pfn)) >>>>> -        return -ENXIO; >>>>> +    p = pfn_to_online_page(pfn); >>>>> +    if (!p) { >>>>> +        struct dev_pagemap *pgmap; >>>>>    -    p = pfn_to_page(pfn); >>>>> +        if (!pfn_valid(pfn)) >>>>> +            return -ENXIO; >>>>> +        pgmap = get_dev_pagemap(pfn, NULL); >>>>> +        if (!pgmap) >>>>> +            return -ENXIO; >>>>> +        put_dev_pagemap(pgmap); >>>>> +        p = pfn_to_page(pfn); >>>>> +    } >>>> >>>> Hm, I wonder if we can do anything reasonable with ZONE_DEVICE pages here? >>> >>> All I can see in unpoison_memory() is folio_test_clear_hwpoison() for ZONE_DEVICE pages. >> >> IIRC, it can only be triggered via debugfs in special kernel configs. So chances are this was never ever actually run against a ZONE_DEVICE page. > > If ZONE_DEVICE pages are never expected, we can simply filter them out. Looking into some details, I think we should just ignore ZONE_DEVICE for now, I'm pretty sure that it's not handled correctly. So I suggest to fail if pfn_to_online_page() == NULL, just like soft_offline_page() would. -- Cheers, David / dhildenb