From: Rik van Riel <riel@surriel.com>
To: Sean Young <sean@mess.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Jarod Wilson <jarod@redhat.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: redrat3: fix UAF in probe error path leaving rc device registered
Date: Sat, 08 Aug 2026 20:59:33 -0400 [thread overview]
Message-ID: <44e707b3577947fa7702b44f79c5dc0f72278409.camel@surriel.com> (raw)
In-Reply-To: <20260808174213.1d68336e@fangorn>
On Sat, 2026-08-08 at 17:42 -0400, Rik van Riel wrote:
> redrat3 stores its device name and phys path inside the main rr3
> structure, and the rc device's device_name and input_phys point into
> rr3. When the RC device is registered, it keeps those pointers.
>
> KASAN: slab-use-after-free in string_nocheck lib/vsprintf.c:648
> Read of size 1 at addr ffff888051fda758 by task udevd/7464
> Call Trace:
> string_nocheck lib/vsprintf.c:648 [inline]
> string+0x216/0x2d0 lib/vsprintf.c:730
> vsnprintf+0x74a/0xef0 lib/vsprintf.c:2945
> vscnprintf+0x41/0x90 lib/vsprintf.c:3014
> sysfs_emit+0x10e/0x180 fs/sysfs/file.c:761
> input_dev_show_name+0x58/0x70 drivers/input/input.c:1282
>
> Allocated by task 10:
> redrat3_dev_probe+0x477/0x2570 drivers/media/rc/redrat3.c:1023
> Freed by task 10:
> redrat3_delete drivers/media/rc/redrat3.c:466 [inline]
> redrat3_dev_probe+0x1bf4/0x2570 drivers/media/rc/redrat3.c:1124
The bug is real, but Sashiko found an issue
with my patch:
https://sashiko.dev/#/patchset/20260808174213.1d68336e%40fangorn
I'll get you a new one that fixes things right.
prev parent reply other threads:[~2026-08-09 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 21:42 Rik van Riel
2026-08-09 0:59 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44e707b3577947fa7702b44f79c5dc0f72278409.camel@surriel.com \
--to=riel@surriel.com \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®