From: Max Staudt <max@enpas.org>
To: Jiri Slaby <jirislaby@kernel.org>,
Eslam Khafagy <eslam.medhat1993@gmail.com>,
roderick.colenbrander@sony.com, jikos@kernel.org,
bentiss@kernel.org
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH v3] HID: memory leak in dualshock4_get_calibration_data
Date: Mon, 24 Nov 2025 23:06:33 +0900 [thread overview]
Message-ID: <44eb6401-e021-4c69-96af-0554f4f31e57@enpas.org> (raw)
In-Reply-To: <6251f6df-d4ac-4681-8e8b-6df2514e655b@kernel.org>
On 11/24/25 3:32 PM, Jiri Slaby wrote:
> Isn't this fixed already by:
> commit 8513c154f8ad7097653dd9bf43d6155e5aad4ab3
> Author: Abdun Nihaal <nihaal@cse.iitm.ac.in>
> Date: Mon Nov 10 22:45:50 2025 +0530
>
> HID: playstation: Fix memory leak in dualshock4_get_calibration_data()
> ?
As far as I can see, that patch does indeed fix the same issue, and it
is already upstream.
Thanks for the hint - Abdun's patch has been upstreamed quite recently,
hence I guess Eslam missed it by accident. But maybe I'm wrong and Eslam
can chime in himself?
> Anyway, this is a typical use-case for __free(). Why not to use that?
Wow, there's been a lot of interesting stuff happening around cleanup.h.
I've been out of the kernel for too long, this looks like fun. Thanks
for pointing it out :)
Max
next prev parent reply other threads:[~2025-11-24 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-22 17:37 Eslam Khafagy
2025-11-22 18:09 ` Max Staudt
2025-11-22 18:15 ` Markus Elfring
2025-11-24 6:32 ` Jiri Slaby
2025-11-24 14:06 ` Max Staudt [this message]
2025-11-25 18:19 ` Eslam Khafagy
2025-11-27 16:55 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44eb6401-e021-4c69-96af-0554f4f31e57@enpas.org \
--to=max@enpas.org \
--cc=bentiss@kernel.org \
--cc=eslam.medhat1993@gmail.com \
--cc=jikos@kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roderick.colenbrander@sony.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®