From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: ChenXiaoSong <chenxiaosong2@huawei.com>, stuyoder@gmail.com
Cc: linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH -next] bus/fsl-mc: fix doc warning
Date: Mon, 7 Jun 2021 15:17:20 +0300 [thread overview]
Message-ID: <44f606cf-ef71-952f-eeb4-1d9f3ce20a67@nxp.com> (raw)
In-Reply-To: <20210607035319.289741-1-chenxiaosong2@huawei.com>
Hi,
On 6/7/2021 6:53 AM, ChenXiaoSong wrote:
> Fix gcc W=1 warning:
>
> drivers/bus/fsl-mc/dprc.c:345: warning: Function parameter or member 'attr' not described in 'dprc_get_attributes'
> drivers/bus/fsl-mc/dprc.c:521: warning: Function parameter or member 'obj_type' not described in 'dprc_get_obj_region'
>
> Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
> ---
> drivers/bus/fsl-mc/dprc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/fsl-mc/dprc.c b/drivers/bus/fsl-mc/dprc.c
> index 27b0a01bad9b..c862e9119b4d 100644
> --- a/drivers/bus/fsl-mc/dprc.c
> +++ b/drivers/bus/fsl-mc/dprc.c
> @@ -334,7 +334,7 @@ int dprc_clear_irq_status(struct fsl_mc_io *mc_io,
> * @mc_io: Pointer to MC portal's I/O object
> * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
> * @token: Token of DPRC object
> - * @attributes Returned container attributes
> + * @attr Returned container attributes
> *
> * Return: '0' on Success; Error code otherwise.
> */
> @@ -504,7 +504,7 @@ EXPORT_SYMBOL_GPL(dprc_set_obj_irq);
> * @mc_io: Pointer to MC portal's I/O object
> * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
> * @token: Token of DPRC object
> - * @obj_type; Object type as returned in dprc_get_obj()
> + * @obj_type: Object type as returned in dprc_get_obj()
> * @obj_id: Unique object instance as returned in dprc_get_obj()
> * @region_index: The specific region to query
> * @region_desc: Returns the requested region descriptor
>
Thanks for the patch. This was already submitted [1] as part of a larger
series [2] by Lee Jones.
[1] https://lore.kernel.org/patchwork/patch/1436378/
[2] https://lore.kernel.org/patchwork/cover/1436375/
---
Best Regards, Laurentiu
prev parent reply other threads:[~2021-06-07 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 3:53 ChenXiaoSong
2021-06-07 12:17 ` Laurentiu Tudor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44f606cf-ef71-952f-eeb4-1d9f3ce20a67@nxp.com \
--to=laurentiu.tudor@nxp.com \
--cc=chenxiaosong2@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stuyoder@gmail.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®