mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@kernel.org>,
	linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] parisc: irq: Trace hardirq state in do_cpu_irq_mask()
Date: Wed, 18 Nov 2026 23:03:30 +0100	[thread overview]
Message-ID: <44f73842-22e2-48fb-b487-8d98b91da7bc@gmx.de> (raw)
In-Reply-To: <20261108192042.14425-1-kmehltretter@gmail.com>

On 11/8/26 20:20, Karl Mehltretter wrote:
> intr_extint calls do_cpu_irq_mask() with PSW[I] already clear. Since
> commit 044d0d6de9f5 ("lockdep: Only trace IRQ edges"), its
> local_irq_disable() then skips trace_hardirqs_off(), and lockdep
> assertions fail in the timer tick:
> 
>    WARNING: kernel/rcu/tree.c:2739 at rcu_sched_clock_irq+0x618/0x1f84
> 
> The return to a context with PSW[I] set has not been annotated since
> TRACE_IRQFLAGS_SUPPORT was enabled. Annotate both transitions.
> 
> Fixes: 366dd4ea9d5f ("parisc: Fix ftrace function tracer")
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> Assisted by an LLM.
> 
> Tested under QEMU hppa (32-bit, -smp 2, PREEMPT, PROVE_LOCKING) on
> mainline d48723711bae: 13 to 18 lockdep warnings per boot before, none
> after (two boots each and one with ftrace=irqsoff). Locking selftests
> pass.
> 
> The exit annotation assumes intr_return does not call
> preempt_schedule_irq(). It currently never does: intr_do_preempt tests
> PSW_D rather than PSW_I ("bb,<,n %r20, 31 - PSW_SM_I"), and a kprobe
> saw no calls. Fixing that needs the same annotation after
> preempt_schedule_irq().
> 
>   arch/parisc/kernel/irq.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
applied.

Thanks!
Helge

      reply	other threads:[~2026-11-18 22:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08 19:20 Karl Mehltretter
2026-11-18 22:03 ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44f73842-22e2-48fb-b487-8d98b91da7bc@gmx.de \
    --to=deller@gmx.de \
    --cc=kmehltretter@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®