From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50031C10F14 for ; Tue, 15 Oct 2019 19:32:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2697C2083B for ; Tue, 15 Oct 2019 19:32:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732122AbfJOTcL (ORCPT ); Tue, 15 Oct 2019 15:32:11 -0400 Received: from smtprelay0149.hostedemail.com ([216.40.44.149]:52271 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726837AbfJOTcK (ORCPT ); Tue, 15 Oct 2019 15:32:10 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 3408B181D341E; Tue, 15 Oct 2019 19:32:09 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: town65_8721e632c0408 X-Filterd-Recvd-Size: 2804 Received: from XPS-9350.home (unknown [47.151.152.152]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Tue, 15 Oct 2019 19:32:08 +0000 (UTC) Message-ID: <44f9a9bde7cf7885a8e55a52260b59240cb9a157.camel@perches.com> Subject: Re: Build failures since 5.4-rc3 From: Joe Perches To: Larry Finger , LKML Date: Tue, 15 Oct 2019 12:32:07 -0700 In-Reply-To: <2da85bba-ab2a-b993-be1a-c98222819b37@lwfinger.net> References: <2da85bba-ab2a-b993-be1a-c98222819b37@lwfinger.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-10-15 at 14:09 -0500, Larry Finger wrote: > Joe, Hey Larry. > Since commit 294f69e662d1("compiler_attributes.h: Add 'fallthrough' pseudo > keyword for switch/case use"), builds of VirtualBox are failing with the > following errors: > > 1954s] In file included from > /usr/src/linux-5.4.0-rc3-1.g2309d7d/include/linux/compiler_types.h:59, > [ 1954s] from : > [ 1954s] > /home/abuild/rpmbuild/BUILD/VirtualBox-6.0.12/modules_build_dir/default/vboxdrv/SUPDrvGip.c: > In function 'supdrvTscDeltaThread': > [ 1954s] > /usr/src/linux-5.4.0-rc3-1.g2309d7d/include/linux/compiler_attributes.h:200:41: > error: expected ')' before '__attribute__' > [ 1954s] 200 | # define fallthrough > __attribute__((__fallthrough__)) > [ 1954s] | ^~~~~~~~~~~~~ > [ 1954s] > /home/abuild/rpmbuild/BUILD/VirtualBox-6.0.12/modules_build_dir/default/vboxdrv/include/iprt/cdefs.h:1169:44: > note: in expansion of macro 'fallthrough' > [ 1954s] 1169 | # define FALL_THROUGH __attribute__ ((fallthrough)) Looks like this should be: #define FALL_THROUGH __attribute__((__fallthrough__)) and there appear to be many of these #defines that use __attribute__((foo)) where foo does not use the double underscored prefix and suffix form I also downloaded and trivially attempted to build vbox without success, but I don't find this #define anywhere in the sources. Clues? $ git clone git://github.com/mirror/vbox.git $ cd vbox $ git grep FALL_THROUGH $ $ ./configure Checking for environment: Determined build machine: linux.amd64, target machine: linux.amd64, OK. Checking for kBuild: ** kmk (variable KBUILDDIR) not found! Check /home/joe/vbox/configure.log for details $ cat configure.log # Log file generated by # # './configure ' # ***** Checking environment ***** Determined build machine: linux.amd64, target machine: linux.amd64 ***** Checking kBuild ***** ** kmk (variable KBUILDDIR) not found! $