Hi Sudip,

On Tue, 6 Sep 2022, 7:32am, Sudip Mukherjee (Codethink) wrote:

> External Email
> 
> ----------------------------------------------------------------------
> Hi All,
> 
> The builds of loongarch loongson3_defconfig have failed to build
> next-20220906 with the error:
> 
> drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_init':
> drivers/scsi/qla2xxx/qla_os.c:2854:25: error: implicit declaration of function 'trace_array_get_by_name'; did you mean 'trace_array_set_clr_event'? [-Werror=implicit-function-declaration]
>  2854 |         qla_trc_array = trace_array_get_by_name("qla2xxx");
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~
>       |                         trace_array_set_clr_event
> 
> drivers/scsi/qla2xxx/qla_os.c: In function 'qla_trace_uninit':
> drivers/scsi/qla2xxx/qla_os.c:2869:9: error: implicit declaration of function 'trace_array_put' [-Werror=implicit-function-declaration]
>  2869 |         trace_array_put(qla_trc_array);
>       |         ^~~~~~~~~~~~~~~
> 
> 
> git bisect pointed to 8bfc149ba24c ("scsi: qla2xxx: Enhance driver tracing with separate tunable and more").
> 
> I will be happy to test any patch or provide any extra log if needed.
> 
> 

This looks like is happening due to CONFIG_TRACING not being enabled (same 
as what kernel test bot reported). Could you try out the fix attached?

@Steven, please see the patch attached. Do you think the fix belongs 
better in linux/trace.h ?

Regards,
-Arun