From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD75C43219 for ; Fri, 3 May 2019 06:59:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A08F205F4 for ; Fri, 3 May 2019 06:59:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727271AbfECG7a (ORCPT ); Fri, 3 May 2019 02:59:30 -0400 Received: from ozlabs.org ([203.11.71.1]:40339 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727254AbfECG73 (ORCPT ); Fri, 3 May 2019 02:59:29 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 44wNKW0jBxz9sPT; Fri, 3 May 2019 16:59:26 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 7e8039795a80bdf1418964b9cabef6168bc5d9a4 X-Patchwork-Hint: ignore In-Reply-To: <20190430010923.17092-1-tobin@kernel.org> To: "Tobin C. Harding" , Benjamin Herrenschmidt , Paul Mackerras From: Michael Ellerman Cc: Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, "Tobin C. Harding" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc: Fix kobject memleak Message-Id: <44wNKW0jBxz9sPT@ozlabs.org> Date: Fri, 3 May 2019 16:59:26 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-04-30 at 01:09:23 UTC, "Tobin C. Harding" wrote: > Currently error return from kobject_init_and_add() is not followed by a > call to kobject_put(). This means there is a memory leak. > > Add call to kobject_put() in error path of kobject_init_and_add(). > > Signed-off-by: Tobin C. Harding > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Tyrel Datwyler Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/7e8039795a80bdf1418964b9cabef616 cheers