From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: bcollins@debian.org, scjody@modernduck.com,
linux1394-devel@lists.sourceforge.net,
kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: set power state of firewire host during suspend
Date: Thu, 07 Sep 2006 22:05:32 +0200 [thread overview]
Message-ID: <45007B8C.5090002@s5r6.in-berlin.de> (raw)
In-Reply-To: <20060905081426.GA4105@elf.ucw.cz>
Pavel Machek wrote:
> Put firewire host controller in PCI Dx state for system suspend.
> (I was not able to measure any power savings, but it sounds like right
> thing to do, anyway.)
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>
[...]
> --- a/drivers/ieee1394/ohci1394.c
> +++ b/drivers/ieee1394/ohci1394.c
> @@ -3565,6 +3565,7 @@ static int ohci1394_pci_suspend (struct
> }
> #endif
>
> + pci_set_power_state(pdev, pci_choose_state(pdev, state));
> return 0;
> }
The order with existing PPC_PMAC code needs to be swapped. And the
resume hook should set the power state too, right? I will post an update
patch soon.
--
Stefan Richter
-=====-=-==- =--= --===
http://arcgraph.de/sr/
prev parent reply other threads:[~2006-09-07 20:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-05 8:14 Pavel Machek
2006-09-05 10:36 ` Stefan Richter
2006-09-05 11:03 ` Pavel Machek
2006-09-07 20:05 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45007B8C.5090002@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@osdl.org \
--cc=bcollins@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=pavel@ucw.cz \
--cc=scjody@modernduck.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®