Re: [PATCH v1] Bluetooth: btmtk: Add MT7928 support

[Paul Menzel <pmenzel@molgen.mpg.de>]

Dear Chris,


Thank you for your answer, and sending in v2.

Am 17.06.26 um 04:16 schrieb Chris Lu (陸稚泓):

> On Tue, 2026-06-16 at 12:24 +0200, Paul Menzel wrote:

>> Am 16.06.26 um 05:01 schrieb Chris Lu:
>>> Add support for MT7928 (device ID 0x7935) which requires additional
>>> firmware (CBMCU firmware) loading before Bluetooth firmware.
>>
>> Please detail what CBMCU firmware is.
> 
> CBMCU is a new component on MT7928 to handle common part shared across
> the combo chip (Wi-Fi/Bluetooth's subsystem), providing a better user
> experience through improved coordination between subsystems.

Thank you, but please add it to the commit message.

>>> Implement two-phase CBMCU firmware download: Phase 1 loads
>>> section with type 0x5 containing global descriptor,
>>> section maps and signature data; Phase 2 loads remaining
>>> firmware sections. Add retry mechanism for concurrent download
>>> protection.
>>
>> What is type 0x5? How big is the firmware, and how long does it take?
>>
>>> After CBMCU firmware loads successfully, the driver continues
>>> to load corresponding BT firmware based on device ID through
>>> fallthrough to case 0x7922/0x7925.
>>
>> Please add the new log message to the commit message.

Thank you for adding those. Please also mention, where to find the new 
firmware.

[…]


Kind regards,

Paul


PS: Also, Pauli’s question should be answered in the commit message 
(internal/external name). (If questions show up during review, it’s a 
good indicator to amend the commit message answering these questions.)