From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752410AbaFJOFZ (ORCPT ); Tue, 10 Jun 2014 10:05:25 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:61133 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142AbaFJOFW (ORCPT ); Tue, 10 Jun 2014 10:05:22 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Tomasz Figa , Pankaj Dubey , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Abraham , kgene.kim@samsung.com, Russell King Subject: Re: [PATCH v3 3/6] ARM: EXYNOS: Remove soc_is_exynos4/5 from exynos.c Date: Tue, 10 Jun 2014 16:04:47 +0200 Message-ID: <4504625.aXgUF2A4Cb@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <53970E3D.9080501@samsung.com> References: <1399706287-13919-1-git-send-email-y@samsung.com> <1399706419-13976-4-git-send-email-pankaj.dubey@samsung.com> <53970E3D.9080501@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V02:K0:cLCydQtIzV/gL1LKKg9lPImM9s6QMPgHTCxXPJcZ+7P WhBBP/VJuZJXN1wjclJ1C9LZ/V7Aa2+KG4vfDvRWRMOKu57E1T pXbR3Y3VyGB99icAyly9vwbma1Ht/qn6uOg/lwZxAyZUbf5aIi VdbsSUvaCuVfIirERbibm1MVupm0mFx3fYDSv7zmCVEXCH1KoP q/o+S1V5V7RVmiRojfoVIFG3tZAdW7t8BIgvhHvDxcnrftDNWS RmR0g/jjtwixSvKqGocMUMEh5QHDamxNSeWKIiVQofHKX0wzE6 EN2tBBThp8Y1JnafL3+9Ve+XEcyhL6aTuFuMEKdtm7334ukzJW ETHCvztLt75k7vtbyhys= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 10 June 2014 15:55:09 Tomasz Figa wrote: > On 10.05.2014 09:20, Pankaj Dubey wrote: > > This patch removes usage of soc_is_exynos4/5 from exynos.c. > > For this we need to separate machine descriptors for exynos4 > > and exynos5. While doing this patch does some consolidation also. > > > > CC: Russell King > > CC: Thomas Abraham > > Signed-off-by: Pankaj Dubey > > --- > > arch/arm/mach-exynos/exynos.c | 52 +++++++++++++++++++----------- > > arch/arm/plat-samsung/include/plat/cpu.h | 3 -- > > 2 files changed, 33 insertions(+), 22 deletions(-) > > > > I don't think this is needed. All those static mappings should just go > away, which will also eliminate the need to have separate machine > descriptor or soc_is_exynos{4,5}() macros. I think I suggested doing this patch as an intermediate step to get rid of the macros first, so we don't get any new users. I agree that we should also remove the static mappings eventually, and once we do that, the machine descriptors can be unified again. I have not checked which of the map_desc entries are currently used at all, or what it would take to remove them. Arnd