From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753506AbdLDKlQ (ORCPT ); Mon, 4 Dec 2017 05:41:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48820 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbdLDKlJ (ORCPT ); Mon, 4 Dec 2017 05:41:09 -0500 Subject: Re: [PATCH] KVM: x86: MMU: make array audit_point_name static To: Colin King , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171130120422.4783-1-colin.king@canonical.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <45047bd6-4a27-2c16-b00b-bb7911792b8f@redhat.com> Date: Mon, 4 Dec 2017 11:41:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171130120422.4783-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 04 Dec 2017 10:41:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.11.2017 13:04, Colin King wrote: > From: Colin Ian King > > The array audit_point_name is local to the source and does not need to > be in global scope, so make it static. > > Cleans up sparse warning: > arch/x86/kvm/mmu_audit.c:22:12: warning: symbol 'audit_point_name' was > not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > arch/x86/kvm/mmu_audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/mmu_audit.c b/arch/x86/kvm/mmu_audit.c > index d22ddbdf5e6e..1272861e77b9 100644 > --- a/arch/x86/kvm/mmu_audit.c > +++ b/arch/x86/kvm/mmu_audit.c > @@ -19,7 +19,7 @@ > > #include > > -char const *audit_point_name[] = { > +static char const *audit_point_name[] = { > "pre page fault", > "post page fault", > "pre pte write", > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb