From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A9EE1F12F6 for ; Fri, 27 Dec 2024 10:48:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735296524; cv=none; b=cROko1Z+6f/wFdBtjYpul78WMruOkmeOvpJO/FzrZD7Z0DFt4k/fz6nCGOwcrhAEfir0cCAMq/5Y0O6sg6R8t36Jirmeg0XnCQu3+UjM3I6ogCmzhYglWvTa3SWdyo7+iJUmhCc3Yhnc8OVH9XAGZhpkAr4FAVWW38TTlTvj0Bk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735296524; c=relaxed/simple; bh=kzNdTzZDggQJ8/2fKfp5bLsqO0zNgzfSIPz8Je6XHH8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z7HqXt1HdQGKCbuqR8BT+SNOf4qT5NTaEFQIGhxt7N8A7kPtRLmHBSpDbD3WARsWSQ2sU+ZpcwlIcPm2GoF1vchebxH6XakVv0Q4s4GliVBF5P75I246ZlLh8XKmgFo6RVNZ1hJbbr6k6KBBwy7wwIKDeJ6IsrMGZo3qIBzKKiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=pQP/lRW/; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="pQP/lRW/" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BQMGYEJ024107; Fri, 27 Dec 2024 10:48:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=qX1JwJ Fs4amPQV6ymBryid5NmZW7BXREfgiR4wYrmZQ=; b=pQP/lRW/0D7ZD8YLkR2R4e GRMS2v66zjN08S+4fgnKpQiRskyaGNu66TGj9O3hIakH5megbenYxqwLVqNc4kbF gg321vHP1/vAlyd6EG11NGk9OgjVz78too/i9es0IU4JtgLWnecbJI7nog20LSE8 b2UozyrRW1osrqtdAUbEQY6mkoQubZjkqKcdf0JxHtnOi2FRcYvbWXRFWCsuZzAS tpt+/XDyc9LPModZnfkM/sKECQ+T29GrSIuR5Aq+Rtf6b1p8DMffPpDv5QSiNTFr alMIxfupvd0ydlAS2wXkSQv8aQB8lNyEnyIiXpzK0v0DPN1WpBKTJtn80uy1YijQ == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43s8m4ucy6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:48:34 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BRAmX78025692; Fri, 27 Dec 2024 10:48:33 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43s8m4ucy0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:48:33 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BR73weq002321; Fri, 27 Dec 2024 10:48:32 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 43p80swq0y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:48:32 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BRAmWfn26870416 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Dec 2024 10:48:32 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0A64558050; Fri, 27 Dec 2024 10:48:32 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A136358045; Fri, 27 Dec 2024 10:48:26 +0000 (GMT) Received: from [9.179.17.222] (unknown [9.179.17.222]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 27 Dec 2024 10:48:26 +0000 (GMT) Message-ID: <4504da8d-a5e7-45a1-9feb-167f94210200@linux.ibm.com> Date: Fri, 27 Dec 2024 16:18:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints To: Gregory Price , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-5-gourry@gourry.net> Content-Language: en-US From: Donet Tom In-Reply-To: <20241210213744.2968-5-gourry@gourry.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: DUwLMLLUpwut_fwoqbkDgoDr4BzEzhiz X-Proofpoint-ORIG-GUID: C-t57Cr-vnzlHDqxym3u5cHb58PSL5Rl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 clxscore=1015 mlxscore=0 bulkscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412270082 On 12/11/24 03:07, Gregory Price wrote: > Count non-page-fault events as page-cache numa hints instead of > fault hints in vmstat. Add a define to select the hint type to > keep the code clean. > > Signed-off-by: Gregory Price > --- > include/linux/vm_event_item.h | 8 ++++++++ > mm/memory.c | 6 +++--- > mm/vmstat.c | 2 ++ > 3 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > index f70d0958095c..c5abb0f7cca7 100644 > --- a/include/linux/vm_event_item.h > +++ b/include/linux/vm_event_item.h > @@ -63,6 +63,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > NUMA_HUGE_PTE_UPDATES, > NUMA_HINT_FAULTS, > NUMA_HINT_FAULTS_LOCAL, > + NUMA_HINT_PAGE_CACHE, > + NUMA_HINT_PAGE_CACHE_LOCAL, > NUMA_PAGE_MIGRATE, > #endif > #ifdef CONFIG_MIGRATION > @@ -185,6 +187,12 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > NR_VM_EVENT_ITEMS > }; > > +#ifdef CONFIG_NUMA_BALANCING > +#define NUMA_HINT_TYPE(vmf) (vmf ? NUMA_HINT_FAULTS : NUMA_HINT_PAGE_CACHE) > +#define NUMA_HINT_TYPE_LOCAL(vmf) (vmf ? NUMA_HINT_FAULTS_LOCAL : \ > + NUMA_HINT_PAGE_CACHE_LOCAL) > +#endif > + > #ifndef CONFIG_TRANSPARENT_HUGEPAGE > #define THP_FILE_ALLOC ({ BUILD_BUG(); 0; }) > #define THP_FILE_FALLBACK ({ BUILD_BUG(); 0; }) > diff --git a/mm/memory.c b/mm/memory.c > index af7ba56a4e1e..620e2045af7b 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5578,10 +5578,10 @@ int numa_migrate_check(struct folio *folio, struct vm_fault *vmf, > *last_cpupid = folio_last_cpupid(folio); > > #ifdef CONFIG_NUMA_BALANCING > - count_vm_numa_event(NUMA_HINT_FAULTS); > - count_memcg_folio_events(folio, NUMA_HINT_FAULTS, 1); > + count_vm_numa_event(NUMA_HINT_TYPE(vmf)); > + count_memcg_folio_events(folio, NUMA_HINT_TYPE(vmf), 1); > if (folio_nid(folio) == numa_node_id()) { > - count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL); > + count_vm_numa_event(NUMA_HINT_TYPE_LOCAL(vmf)); I have tested this patch series on my system with my test program. I am able to see unmapped page cache pages are getting promoted. numa_hint_faults2269numa_hint_faults_local2245numa_hint_page_cache1244numa_hint_page_cache_local0numa_pages_migrated4501 In my test result numa_hint_page_cache_local is 0. I am seeing numa_hint_page_cache_local will only be incremented if the folio's node and the process's running node are the same. This condition does not occur in the current implementation, correct? Thanks Donet > *flags |= TNF_FAULT_LOCAL; > } > #endif > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 4d016314a56c..bcd9be11e957 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1338,6 +1338,8 @@ const char * const vmstat_text[] = { > "numa_huge_pte_updates", > "numa_hint_faults", > "numa_hint_faults_local", > + "numa_hint_page_cache", > + "numa_hint_page_cache_local", > "numa_pages_migrated", > #endif > #ifdef CONFIG_MIGRATION