From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
alexandra.yates@linux.intel.com, Len Brown <len.brown@intel.com>,
open list <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG
Date: Wed, 16 Sep 2015 04:48:37 +0200 [thread overview]
Message-ID: <4506267.XG2T0Et70c@vostro.rjw.lan> (raw)
In-Reply-To: <20150916020023.GB29235@linux>
On Wednesday, September 16, 2015 07:30:23 AM Viresh Kumar wrote:
> On 16-09-15, 03:43, Rafael J. Wysocki wrote:
> > On Tuesday, September 15, 2015 01:42:21 PM Viresh Kumar wrote:
> > > The variable 'wakeup_irq' is defined within #ifdef CONFIG_PM_SLEEP_DEBUG
> > > and used outside of it. And that breaks kernel build:
> > >
> > > /home/viresh/linux/drivers/base/power/wakeup.c:871: undefined reference to `wakeup_irq'
> > > /home/viresh/drivers/base/power/wakeup.c:871: undefined reference to `wakeup_irq'
> > >
> > > Fix it by defining the variable outside of the ifdef.
> > >
> > > Fixes: d1e59c235322 ("PM / sleep: Report interrupt that caused system wakeup")
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > I've applied the v11 of the Alexandra's patch that doesn't have this problem AFAICS.
>
> For the record, as we have talked on IRC, even the v11 patch suffers
> from this problem and you will be fixing it.
Yes, it was slightly messed up. Should be better now, though.
Thanks,
Rafael
next prev parent reply other threads:[~2015-09-16 2:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 8:12 Viresh Kumar
2015-09-15 11:02 ` Pavel Machek
2015-09-16 1:43 ` Rafael J. Wysocki
2015-09-16 2:00 ` Viresh Kumar
2015-09-16 2:48 ` Rafael J. Wysocki [this message]
2015-09-16 2:54 ` Rafael J. Wysocki
2015-09-16 2:30 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4506267.XG2T0Et70c@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=alexandra.yates@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®