From: Johannes Berg <johannes@sipsolutions.net>
To: Zhao Li <enderaoelyther@gmail.com>, linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Jaewan Kim <jaewan@google.com>,
Daniel Gabay <daniel.gabay@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Benjamin Berg <benjamin.berg@intel.com>,
Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>,
Peddolla Harshavardhan Reddy <peddolla.reddy@oss.qualcomm.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
John Crispin <john@phrozen.org>,
Avinash Patil <patila@marvell.com>, Cathy Luo <cluo@marvell.com>,
"John W. Linville" <linville@tuxdriver.com>,
Aloka Dixit <quic_alokad@quicinc.com>
Subject: Re: [PATCH 8/8] wifi: nl80211: clean up color-change beacon data on errors
Date: Wed, 22 Jul 2026 16:31:48 +0200 [thread overview]
Message-ID: <450be3831c5e0234c309d4c04641a42c6ac4f2b0.camel@sipsolutions.net> (raw)
In-Reply-To: <20260708195911.84365-9-enderaoelyther@gmail.com>
> @@ -18754,11 +18754,13 @@ static int nl80211_color_change(struct sk_buff *skb, struct genl_info *info)
> wdev->links[params.link_id].ap.chandef.chan,
> info->extack);
> if (err)
> - return err;
> + goto out;
>
> tb = kzalloc_objs(*tb, NL80211_ATTR_MAX + 1);
> - if (!tb)
> - return -ENOMEM;
> + if (!tb) {
> + err = -ENOMEM;
> + goto out;
> + }
It'd be simpler for the cleanup to just change the order.
johannes
next prev parent reply other threads:[~2026-07-22 14:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 19:59 [PATCH 0/8] wifi: fix PMSR lifetime and frame validation issues Zhao Li
2026-07-08 19:59 ` [PATCH 1/8] wifi: mac80211_hwsim: clear PMSR request state on abort Zhao Li
2026-07-08 19:59 ` [PATCH 2/8] wifi: mac80211_hwsim: authenticate PMSR report senders Zhao Li
2026-07-08 19:59 ` [PATCH 3/8] wifi: iwlwifi: mld: abort active PMSR requests Zhao Li
2026-07-08 19:59 ` [PATCH 4/8] wifi: cfg80211: guard optional PMSR nominal time Zhao Li
2026-07-08 19:59 ` [PATCH 5/8] wifi: mac80211: validate probe response countdown offsets Zhao Li
2026-07-08 19:59 ` [PATCH 6/8] wifi: mac80211: validate S1G TWT params before driver setup Zhao Li
2026-07-08 19:59 ` [PATCH 7/8] wifi: mwifiex: validate action frame fixed fields Zhao Li
2026-07-08 19:59 ` [PATCH 8/8] wifi: nl80211: clean up color-change beacon data on errors Zhao Li
2026-07-22 14:31 ` Johannes Berg [this message]
2026-07-31 4:02 ` [PATCH v2] " Zhao Li
2026-07-21 16:00 ` [PATCH 0/8] wifi: fix PMSR lifetime and frame validation issues Johannes Berg
2026-07-22 14:37 ` Johannes Berg
2026-07-23 0:25 ` Lachlan Hodges
2026-07-23 8:06 ` Johannes Berg
2026-07-23 1:09 ` Enderaoe Lyther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=450be3831c5e0234c309d4c04641a42c6ac4f2b0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=benjamin.berg@intel.com \
--cc=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=daniel.gabay@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=enderaoelyther@gmail.com \
--cc=francesco@dolcini.it \
--cc=jaewan@google.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lorenzo@kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=pagadala.yesu.anjaneyulu@intel.com \
--cc=patila@marvell.com \
--cc=peddolla.reddy@oss.qualcomm.com \
--cc=quic_alokad@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®