From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3DB22EDD53 for ; Tue, 21 Oct 2025 13:14:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761052445; cv=none; b=onGTJgKXSVc6TAoAlGVKvs9qCQkOgVmoQxmgRunkSxj/XqCByZGbQtKfTOg6krZ72slfBGxMI1kCYzD4Udyyw14t9dLXgUvjMiCg8yBiyWl+zbFnaYkqnxB9ZuHkAwU3zeCJR5qCJSyA86v7HvS8QuwPJcjla8rpeg1SSNK7pHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761052445; c=relaxed/simple; bh=w2i+FxONBXXx3PvM+d1TKTp00ehfZPIgAaTK1j0wkl4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QoFBFornWBeGazrWqeaVqTPHaHBHtZasXXg7Nyfqyz4P1of63XDzqHjRXKw7tECbpqWIYufj7vFJOxNUfC3Jg1O0vjUVKz99hklCy4GBt0LpMRPpBFDwRk9QjKCtqynSoY/nox4vHq1uFpvoBg+2/lacK8+lJJtR3XGX1wWlqxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OHYh3WfO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OHYh3WfO" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59L8LvL2027450 for ; Tue, 21 Oct 2025 13:14:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1J3FwMBpLhx8fYWCDWyhBCXacIdXPm0xifRPcXHEaJ8=; b=OHYh3WfONtQnQIWN jqNqPFtwtmIP6JuNtltLlO5uECBdbthXS+cv6w0vMPNXrYjgT5OBozJ9FUOWeSF3 0vVU4zQyf1ABp5ByavV32Z1Yw8QYcFVMMZQMOgSJA9+/jGsbkhevmCz1xVF5rt9D dmYUdrckZy/8d/BHg5/j5SvzlJqXwBM9xwMWTRywIVniZ9uSD72wA2TWzyVaXldO Tf3ftUzKy/lwH3jKzWcQskpsraeuzVDqItzYJ7YcrrwX54OoOgUSLzxcJ7Gv5yP4 6jEIIbojQtWjgzoOTtbed8Dg4M/+TVBqcFR6yV0WtdZDRRRDfkwF+rweUBiPzAld o4uFRA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v27j0tmu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 21 Oct 2025 13:14:01 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-78e5b6f1296so171479376d6.2 for ; Tue, 21 Oct 2025 06:14:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761052441; x=1761657241; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1J3FwMBpLhx8fYWCDWyhBCXacIdXPm0xifRPcXHEaJ8=; b=UlEEo2SjVvQ5s7qw57cUYFhqBDk57sd+VeTKjYYkoWFIOi72xyAG4c4f1yoTo64LxI 67xog7G6uK8NnZn94/WscKIpjmgdLIp+zfSZP+IE9u4Haziv1FUVNyMuDONLhXpgLv77 78qWSzZhxfgMhkaNuEkwa9cIW182jSY6MoA9WPW+B3a3DIeR4HwqO7vjWFAFaC0XYMJA gYe/qQ/cpUypy/daaJbWM9P37kTesoz2ZYqwUQIP0zDcwBMI6/W1HbVFZrgzBjPQGwd2 VjuhIyVi94XAj2eSMxQBLXGjcTm/F1b1QNZYYM7n4dgUOUGGr7HhVmbAPKk6VI0bKHQs 7kEg== X-Forwarded-Encrypted: i=1; AJvYcCX2rq3rQggxpSsVapI12c2tAkSC850x+sLGn2IjCkvlaJFWOux/8gwHE2w6qw1+XW9IVwEiGwjVvYP0Vzk=@vger.kernel.org X-Gm-Message-State: AOJu0YwMa6BD/TUauawGGjYSWqxS7xVE4+GCgXe0/mGXk9x5tngFwRHv sz5gJvkBXqCn7qyNMNQM/k3cJd2wK3C14le3ywQCqZwMpkuM7AWJXszYMNdTC6oZhboIleA///G arzjKqCiZVW3ef3UBKxn0xWWk4d2qYo16cG9wEqUi4T1ANFObg7zlh47h2gh/UQI9F8w= X-Gm-Gg: ASbGncvEmlnI39JfgbR40eXwWUDrgW8iKvOPPqVSJOpfI+e7yWPYg+hWc1wEx8w9BGA csOcUq3iRsQ22yh4TvM/KncBpC+0meMze4ehCY3/xubO7PXsdUN/Mfz9jXsHGI0/MfsIzn75C4r Vx4EQXo19+nHrZrHCgDeTZr612XnJsUIbE4gSYJ+Fmif/hggUPVtIRRIiDLLzuXpV6f9HeSk474 C3TGezIab2Gpxc19UpU9PGItfVXrE5LmF/suXqH357kLAaeAKpDWpIXm4z8KAElsXb7Y3udYZqz VrjM2ri4TH3fIIpTsTgfF6BIsk2lwLgVzT71BXmG51BT6DYww+TqTTv5m61C8xBltdAFh5P0y9f +ICa4gYogYkF74zXjzFlw05Mxqg== X-Received: by 2002:ac8:5fd0:0:b0:4df:a3f1:2b41 with SMTP id d75a77b69052e-4e89d2f2d22mr191979261cf.37.1761052440976; Tue, 21 Oct 2025 06:14:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMR85aYmO0SlEiPplaQeeABFnTh46S57hFvtLZYcoP7my3aQJA/qcKSdNST7j3T+8HnZ1Sug== X-Received: by 2002:ac8:5fd0:0:b0:4df:a3f1:2b41 with SMTP id d75a77b69052e-4e89d2f2d22mr191978891cf.37.1761052440479; Tue, 21 Oct 2025 06:14:00 -0700 (PDT) Received: from [192.168.68.121] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-474949e0a3csm18730905e9.0.2025.10.21.06.13.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 06:14:00 -0700 (PDT) Message-ID: <450cac8b-598b-4f47-8bf0-43c805038e7c@oss.qualcomm.com> Date: Tue, 21 Oct 2025 14:13:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: qcm2290: add LPASS LPI pin controller To: Dmitry Baryshkov , Alexey Klimov Cc: Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org References: <20251007-rb1_hdmi_audio-v2-0-821b6a705e4c@linaro.org> <20251007-rb1_hdmi_audio-v2-3-821b6a705e4c@linaro.org> <56vmqgrjy3je7omzirxnfxtuocebbj356iaew5thgkagi35464@hh34y7efssow> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <56vmqgrjy3je7omzirxnfxtuocebbj356iaew5thgkagi35464@hh34y7efssow> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAxOCBTYWx0ZWRfX3PJnc6jOKdh6 WdVd670UuQgeS0Jp4KIbyjyeKLXnKbTEC5jxFM4X88Msht2LnR5EBGvViR8WWnlA2UYXqjhFF1I EF7Pj7mwLgYsioTafP6dpNSW5D6JMCsrvy9wIzedlhy2LU3xJWK73LW/+qbjDelPN04XQQjxbGE HH2OcW3nKj23xCPBnImtAlpend78vfI1vgGyIesSNo+IklH1Ai8UcgCivOZ8HwA3Xovq2wk3b1q N6Um3gBdcXD8aO19Hr/UWM9gc86pBzJf81Zm9ZJQPl2Bg/SbYeDFpsNrjpUCgAAz2rVmuhD6IiM aedPDUjX9HqtPFoZe7IkjKV6pAJlfZjLgMstu7XylA44VDO38zU67zVtLosINwS+SOuD21g1Jb5 y/EFfgvwH2K/4ESUr6SXxCyGRQUEhg== X-Authority-Analysis: v=2.4 cv=G4UR0tk5 c=1 sm=1 tr=0 ts=68f78719 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=S47CMrjrQcjTfVtel-AA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: L3Fzs9GzpS79AHxDnpH2H_ITHLw9ewj6 X-Proofpoint-ORIG-GUID: L3Fzs9GzpS79AHxDnpH2H_ITHLw9ewj6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-21_01,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 spamscore=0 suspectscore=0 adultscore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180018 On 10/21/25 2:03 PM, Dmitry Baryshkov wrote: > On Tue, Oct 21, 2025 at 01:56:09PM +0100, Alexey Klimov wrote: >> On Fri Oct 17, 2025 at 11:42 PM BST, Bjorn Andersson wrote: >>> On Fri, Oct 10, 2025 at 01:29:38PM +0100, Alexey Klimov wrote: >>>> On Tue Oct 7, 2025 at 1:39 PM BST, Konrad Dybcio wrote: >>>>> On 10/7/25 4:03 AM, Alexey Klimov wrote: >>>>>> Add the Low Power Audio SubSystem Low Power Island (LPASS LPI) pin >>>>>> controller device node required for audio subsystem on Qualcomm >>>>>> QRB2210 RB1. QRB2210 is based on qcm2290 which is based on sm6115. >>>>>> >>>>>> While at this, also add description of lpi_i2s2 pins (active state) >>>>>> required for audio playback via HDMI/I2S. >>>>>> >>>>>> Cc: Srinivas Kandagatla >>>>>> Signed-off-by: Alexey Klimov >>>>>> --- >>>>> >>>>> [...] >>>>> >>>>>> + lpi_i2s2_active: lpi-i2s2-active-state { >>>>>> + data-pins { >>>>>> + pins = "gpio12"; >>>>>> + function = "i2s2_data"; >>>>>> + bias-disable; >>>>>> + drive-strength = <8>; >>>>>> + output-high; >>>>> >>>>> I.. doubt output-high is what you want? >>>> >>>> Why? Or is it because of some in-kernel gpiod? >>>> >>> >>> What does "output-high" mean for a non-gpio function? >> >> This is not efficient. It will be more useful to go straight to >> the point. > > It is efficient. It makes everybody think about it (and ask the same > question in future) instead of just depending on maintainers words. > >> This description of pins was taken from Qualcomm downstream code >> and the similar patch was applied (see provided URL in the prev email). > > And we all know that downstream can be buggy, incomplete, etc. > >> Back to your question -- does it matter here if it is gpio or non-gpio >> function? > > It does. The I2S data pin is supposed to be toggled in some way by a > certain IP core. What would it mean if we program output-high? Will the > pin still be toggled (by the function) or stay pulled up (because of the > output being programmed)? I2S lines are configured in push-pull mode which means that the lines are driven high and low actively, am not sure why output-high is needed an what it means here as these lines are actively driven by the controller. @Alexey, what issues do you see without this? Am not sure if pinctrl driver even cares about this if we are in alt mode. --srini>