mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Weili Qian <qianweili@huawei.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Chen Ni <nichen@iscas.ac.cn>, <wangzhou1@hisilicon.com>,
	<davem@davemloft.net>, <xuzaibo@huawei.com>,
	<tanshukun1@huawei.com>, <linux-crypto@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: hisilicon - Add check for pci_find_ext_capability
Date: Wed, 22 Nov 2023 20:11:37 +0800	[thread overview]
Message-ID: <450d30a4-5b01-6e20-3fd7-bee0cead419f@huawei.com> (raw)
In-Reply-To: <ZVdCLjo7GOQN54sx@gondor.apana.org.au>



On 2023/11/17 18:36, Herbert Xu wrote:
> On Fri, Nov 17, 2023 at 10:07:00AM +0800, Weili Qian wrote:
>>
>> Thanks for your patch. The function qm_set_vf_mse() is called only after SRIOV
>> is enabled, so function pci_find_ext_capability() does not return 0. This check
>> makes no sense.
> 
> Perhaps we could add a comment instead?
> 
> Thanks,
> 

Okay, I will add a comment for this.

Thanks,
Weili

      reply	other threads:[~2023-11-22 12:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09  2:13 Chen Ni
2023-11-17  2:07 ` Weili Qian
2023-11-17 10:36   ` Herbert Xu
2023-11-22 12:11     ` Weili Qian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=450d30a4-5b01-6e20-3fd7-bee0cead419f@huawei.com \
    --to=qianweili@huawei.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nichen@iscas.ac.cn \
    --cc=tanshukun1@huawei.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=xuzaibo@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®