From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C31CC7EE29 for ; Tue, 6 Jun 2023 13:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237910AbjFFNFW (ORCPT ); Tue, 6 Jun 2023 09:05:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237942AbjFFNEz (ORCPT ); Tue, 6 Jun 2023 09:04:55 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BCB7118 for ; Tue, 6 Jun 2023 06:04:53 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 747C21FD69; Tue, 6 Jun 2023 13:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1686056692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ry1brdsrJRfV+nz796SZljGut/o/NXUU3oxJv26Cew=; b=QF6dTVenoKaE3oiLugeB9fWdYEAXWNwx6KIFIROhy2vWBkAo216da0Bqn90PZ7G41n4JUn u8CpwKcLiTcUc9WrAB11CU/Q5+vTyICuimywlH1esRXJivfzttJenHL103ePXaVqu9YooU V5z0EwuLHLHkMll5dGKOJwQQ6gTHtIc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1686056692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ry1brdsrJRfV+nz796SZljGut/o/NXUU3oxJv26Cew=; b=r/dVZVQynAjZje8GcSsAReUBc3KUGF3xbQOvV45Ac5iroSPSfiiW61ZShHjyRV+Io6zSuK msNiJesaolwAVnAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 54AC413776; Tue, 6 Jun 2023 13:04:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pcX4E/Quf2RJTwAAMHmgww (envelope-from ); Tue, 06 Jun 2023 13:04:52 +0000 Message-ID: <45151cfc-705a-9424-01c3-c2c7746b10ed@suse.cz> Date: Tue, 6 Jun 2023 15:04:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 6/5] mm: compaction: have compaction_suitable() return bool Content-Language: en-US To: Johannes Weiner , Andrew Morton Cc: Mel Gorman , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com References: <20230519123959.77335-1-hannes@cmpxchg.org> <20230602151204.GD161817@cmpxchg.org> From: Vlastimil Babka In-Reply-To: <20230602151204.GD161817@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/2/23 17:12, Johannes Weiner wrote: > Since it only returns COMPACT_CONTINUE or COMPACT_SKIPPED now, a bool > return value simplifies the callsites. > > Suggested-by: Vlastimil Babka > Signed-off-by: Johannes Weiner Acked-by: Vlastimil Babka Thanks!