mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Quan Nguyen <quan@os.amperecomputing.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	openbmc@lists.ozlabs.org, Arnd Bergmann <arnd@arndb.de>,
	Olof Johansson <olof@lixom.net>,
	soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
	Open Source Submission <patches@amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>, thang@os.amperecomputing.com
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: aspeed: document Ampere Mt.Mitchell BMC compatibles
Date: Thu, 21 Jul 2022 09:46:42 +0700	[thread overview]
Message-ID: <4516d7a6-f493-aa51-2700-bbab8ea8533a@os.amperecomputing.com> (raw)
In-Reply-To: <0a5cbaaa-565a-7215-5e31-12c52f4bbcbd@linaro.org>



On 20/07/2022 17:34, Krzysztof Kozlowski wrote:
> On 20/07/2022 10:52, Quan Nguyen wrote:
>> Document Ampere Mt.Mitchell BMC board compatible.
>>
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> 
> Thank you for your patch. There is something to discuss/improve.
> 
>> ---
>> v2:
>>    + Introduce in v2 to add Ampere Mt. Mitchell BMC compatible [Krzysztof]
>>
>>   Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> index d61408194998..b8146d5c4431 100644
>> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>> @@ -71,6 +71,7 @@ properties:
>>             - enum:
>>                 - aspeed,ast2600-evb
>>                 - aspeed,ast2600-evb-a1
>> +              - ampere,mtmitchell-bmc
> 
> Put the entry ordered alphabetically.
> 

Thanks Krzysztof for the review.

Will change to :
              - enum:
  +              - ampere,mtmitchell-bmc
                 - aspeed,ast2600-evb
                 - aspeed,ast2600-evb-a1

But, should we correct the below as well? ie: to move 
"ampere,mtjade-bmc" to before "aspeed,ast2500-evb" ?

- description: AST2500 based boards
         items:
           - enum:
               - aspeed,ast2500-evb
               - amd,ethanolx-bmc
               - ampere,mtjade-bmc
               - asrock,e3c246d4i-bmc

Thanks,
- Quan

  reply	other threads:[~2022-07-21  2:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20  8:52 [PATCH v2 0/2] Add device tree for Ampere's Mt. Mitchell BMC Quan Nguyen
2022-07-20  8:52 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: document Ampere Mt.Mitchell BMC compatibles Quan Nguyen
2022-07-20 10:34   ` Krzysztof Kozlowski
2022-07-21  2:46     ` Quan Nguyen [this message]
2022-07-21  7:11       ` Krzysztof Kozlowski
2022-07-20  8:52 ` [PATCH v2 2/2] ARM: dts: aspeed: Add device tree for Ampere's Mt. Mitchell BMC Quan Nguyen
2022-07-20 10:36   ` Krzysztof Kozlowski
2022-07-21  2:46     ` Quan Nguyen
2022-07-21  2:02   ` Andrew Jeffery
2022-08-15  6:20     ` Quan Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4516d7a6-f493-aa51-2700-bbab8ea8533a@os.amperecomputing.com \
    --to=quan@os.amperecomputing.com \
    --cc=andrew@aj.id.au \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=openbmc@lists.ozlabs.org \
    --cc=patches@amperecomputing.com \
    --cc=phong@os.amperecomputing.com \
    --cc=robh+dt@kernel.org \
    --cc=soc@kernel.org \
    --cc=thang@os.amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®