From: "Masoud Sharbiani" <masouds@google.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Andi Kleen" <ak@suse.de>, "Kirill Korotaev" <dev@openvz.org>,
linux-kernel@vger.kernel.org
Subject: Re: i386-show-unhandled-signals-v3
Date: Wed, 25 Jul 2007 20:21:28 -0700 [thread overview]
Message-ID: <4517d1380707252021j1c7af370wcd23edebd3085c51@mail.gmail.com> (raw)
In-Reply-To: <20070725165805.1bcd5a02.akpm@linux-foundation.org>
On 7/25/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Wed, 25 Jul 2007 16:40:06 -0700
> masouds@google.com (Masoud Asgharifard Sharbiani) wrote:
>
> > > Look: if there's a way in which an unprivileged user can trigger a printk
> > > we fix it, end of story. I don't know why this even slightly
> > > controversial.
> > >
> >
> > Fair enough. Here it is:
>
> My favourite words.
>
> > ---------------
> > Hello,
> > This patch makes the i386 behave the same way that x86_64 does when a
> > segfault happens. A line gets printed to the kernel log so that tools
> > that need to check for failures can behave more uniformly between
> > different kernels. Like x86_64, it can be disabled by setting
> > debug.show_unhandled_signals sysctl variable to 0 (or by doing
> > echo 0 > /proc/sys/debug/show_unhandled_signals)
>
> Do we really need the ratelimiting? If the admin turns this on then he's
> presumably prepared for the consequences.
>
> I guess "yes", as people (even distros) are likely to turn this on and
> forget about it.
>
> The patch is larger than I expected, ho hum.
>
So, we happy? What else I can chop from this patch to make it more
acceptable for the people involved?
Please be advised that with this patch, the old exception_trace that
was enabled becomes disabled by default; x86_64 had that enabled, and
i386 didn't have anything...
cheers,
Masoud
next prev parent reply other threads:[~2007-07-26 3:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 15:47 i386-show-unhandled-signals-v3 Masoud Asgharifard Sharbiani
2007-07-25 14:45 ` i386-show-unhandled-signals-v3 Kirill Korotaev
2007-07-25 14:50 ` i386-show-unhandled-signals-v3 Masoud Sharbiani
2007-07-25 15:01 ` i386-show-unhandled-signals-v3 Kirill Korotaev
2007-07-25 14:57 ` i386-show-unhandled-signals-v3 Andi Kleen
2007-07-25 21:04 ` i386-show-unhandled-signals-v3 Andrew Morton
2007-07-25 21:07 ` i386-show-unhandled-signals-v3 Masoud Sharbiani
2007-07-25 23:25 ` i386-show-unhandled-signals-v3 Andrew Morton
2007-07-25 23:40 ` i386-show-unhandled-signals-v3 Masoud Asgharifard Sharbiani
2007-07-25 23:58 ` i386-show-unhandled-signals-v3 Andrew Morton
2007-07-26 3:21 ` Masoud Sharbiani [this message]
2007-07-26 4:15 ` i386-show-unhandled-signals-v3 Andrew Morton
2007-07-26 9:13 ` i386-show-unhandled-signals-v3 Rene Herman
2007-07-26 9:46 ` i386-show-unhandled-signals-v3 Andi Kleen
2007-07-26 10:14 ` i386-show-unhandled-signals-v3 Andrew Morton
2007-07-26 11:59 ` i386-show-unhandled-signals-v3 Andi Kleen
2007-07-26 12:18 ` i386-show-unhandled-signals-v3 Alan Cox
2007-07-26 10:16 ` i386-show-unhandled-signals-v3 Alan Cox
2007-07-26 10:17 ` i386-show-unhandled-signals-v3 Rene Herman
2007-07-26 10:25 ` i386-show-unhandled-signals-v3 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4517d1380707252021j1c7af370wcd23edebd3085c51@mail.gmail.com \
--to=masouds@google.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dev@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®