mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vincent Legoll <legoll@online.fr>
To: linux-kernel@vger.kernel.org
Cc: torvalds@osdl.org, ak@suse.de, Vincent Legoll <vincent.legoll@gmail.com>
Subject: [PATCH] off-by-one in kernel command line option parsing
Date: Sat, 30 Sep 2006 20:20:28 +0200	[thread overview]
Message-ID: <451EB56C.9020105@online.fr> (raw)

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

Here is a patch for what I think is a bug in the kernel,
please comment / apply as appropriate.

Generated by cg-mkpatch from a fairly recent git tree.
Cross-compile tested.

-- 
Vincent Legoll


[-- Attachment #2: opt-parse.patch --]
[-- Type: text/plain, Size: 845 bytes --]

fix memcmp() off-by-one
nolapic is 7 chars long

---
commit aa2cb4b05c437005ccff44084678948c99aa62b3
tree 54ddca6ab0ef9a29bb1ff0f452b1eaccce7b33a1
parent 4ed4b5475211fab6a0ad00eed2f9297395e7598e
author Vincent Legoll <vincent.legoll@gmail.com> Sat, 30 Sep 2006 18:52:53 +0200
committer Vincent Legoll <vincent.legoll@gmail.com> Sat, 30 Sep 2006 18:52:53 +0200

 arch/i386/kernel/setup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
index f168220..72bbf22 100644
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -869,7 +869,7 @@ #ifdef CONFIG_X86_LOCAL_APIC
 			lapic_enable();
 
 		/* disable local APIC */
-		else if (!memcmp(from, "nolapic", 6))
+		else if (!memcmp(from, "nolapic", 7))
 			lapic_disable();
 #endif /* CONFIG_X86_LOCAL_APIC */
 

             reply	other threads:[~2006-09-30 18:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-30 18:20 Vincent Legoll [this message]
2006-09-30 18:25 ` Andi Kleen
2006-09-30 18:32   ` Vincent Legoll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451EB56C.9020105@online.fr \
    --to=legoll@online.fr \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=vincent.legoll@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®