From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D23E3B47EF for ; Fri, 27 Mar 2026 11:23:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774610589; cv=none; b=iVVZkaX1w0fURb+3xUL+rWYtC12kHriJkyPmdrYx3XlayfrnZb9U86bpHv2e+4Zwod41dBCN+6b3pjgp9i7lAgO6RptiGg25fHmr4o7gmg6Etea7lvtORrOlOa67SmmUsTNFpaxnafQWGjidZa5DyIvj4dMQp4R77JZdIkfCok8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774610589; c=relaxed/simple; bh=ZE64kQlavJURXdGjYq/7SVLot5CU4XBtX/mc6JwRh+E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pv/1N52dAzjqxxUkav20RntIVopKaUFKJjhTabBIrWtCqGRXOxGrvrWgksnbcf7sVKOoyKX4sADdAAiQzHcgIETN5of8pAVLzESANY0xjwar02qiemfozfAeL83wvd8HWh+Fd8NcFAPf3mUgBQyEJVBel3o/S4nG32i+s2N3e8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NETvdQfy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y6oQtMUJ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NETvdQfy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y6oQtMUJ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62R6wEtT1710545 for ; Fri, 27 Mar 2026 11:23:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3w2ktYkEZdHcxeWiM/YwaRWS3HtqT2nSX/T7SXyb4qo=; b=NETvdQfyuCGPcouJ H0byEs5stHDvAV+ALpQ6mtv9aVZquPL7CbJrIkQqfbDolKrp1f5F4OyzTk98aWxg 4IjtkoIdBRB1YWcQLbRjKMlCxaaGgVahJtkZYVT0SOCjov8pMHg5aVipfqT13kcb q8N4VBn6bHs492y6qXp3JzeRbkHOi9UF3CfoYBbbK1KUSgR3mLRYxr4XpCVLpBo2 ahrORFU8J7iZX0R0niTBKWHJH8f7/Rzv7ozbuySeWAp/nYNPCcITBWkYObPhKwQc BpvQ6djcr9dQNfeV782fkJeyDhU4GnIxPzO/MR95hav4tiiLmGido1DbEdU/+AjG xIiyZg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5bxvjrhp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 11:23:06 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb485c686cso66866685a.1 for ; Fri, 27 Mar 2026 04:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774610586; x=1775215386; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3w2ktYkEZdHcxeWiM/YwaRWS3HtqT2nSX/T7SXyb4qo=; b=Y6oQtMUJwfobz5kb6TCGCIgfsiECAKu74D1wbZNTL3JREtjvt9Wf5uCmcqPFA9VKwV vD7Dpz2ZleY5kTi3BtUv0cOzH0Oc3/na/8LA8zcqRa0MujrsXYsGFyjnmZAymcAkHYoP YuzYi1SySRx1djYeIzwfC3iY5bObwT+PKk9zgPIfQ7BE7Ja6qh8oB+6sLVIPx2cwWKG5 51fatDXgquqLyQJm+tB+Bo4CF9feyRm1CRywwy0DRaEnrCK98MOjza7cu74Vcj5n9qOY mWH0luLZcHNAjfjkiB9LVqVOjxRZewNfP8cc40b+p+kSkGerAnudYaD/Ln1zsosz3yWd sQXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774610586; x=1775215386; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3w2ktYkEZdHcxeWiM/YwaRWS3HtqT2nSX/T7SXyb4qo=; b=keRqR/dzmwPodACiquo4bQUvG42c4/iBLC++1pdVhSS6bPjvCoMtSjbHoZBgTvmQWy ZWQCiipGl4nwU/ThifRrICqnIdPWKRO7ZjxBpNBmAjT1AGSTo7hRNV4WRb5j76OoT03A JQtcelTvt/Ze8VOCn9Bs1h2CH3ww4tMdTs9tFft0w8Kep/D7tO3xlyd9lNrYTIlfbivn LjH4cFh4XaUOVHapjLlDdfWMEWBhWgngHMDWiy8W4xuLzGDLuNhMFNgacEqBVSus8+Zl ad9CtZVIulJ0Ip6FIuZbntZKIwDneFsmHoDk4l+kK9YAEEvbwLphRv5rK3j1IxRm67RF eRYg== X-Forwarded-Encrypted: i=1; AJvYcCXCI8DeKV9Ijt1+aT4h9acSD037Vn6Kjp34uheQz+wXALIdwAHk7mhcDwRGMPDX7k4Hyf9xCHlZECXdgF4=@vger.kernel.org X-Gm-Message-State: AOJu0YyNUSB5QLDGOkGT0MpShy9s6vIXtWEWLcjERaYp0+ZyMJJWOmTC IMb/wAAsfIhqh2Rl3GGLmEPC8BROqsaojtZuXlL+6EAYIU1fQXkHVfX7CIHmRBxCxG98ib5lN1/ cralqbmpYzEHm4qp002VEAhlAPldPiTkCSoRArHl+nC67QF8FhR6GsxF6d9vPGdieUfk= X-Gm-Gg: ATEYQzwqYDZGCvTqZMDzMMYpOCw69hyWauw2Jc4FJ8nXKzdShjXH6rHG6ocqyN9fDJg EoOneBr8B+gYnTWmatkzTBoSi8fneXAMHXemwu6vyoyooQUwb3Aw8vmPEtVKdW2sDtPRABthDxm NcRiCYBpEoQGjy3DY67wJC9ffwWtNklbQQIvnp3uGe27/Pp+vnc961FSh2jkOMB7i/k26APJFJw hFUUtJjYcbHLooahsdD5eHpn9hi6BMxyaA/M68D2iM30IN2vnr/m+MPvju50lXtpXEmSlaXN1aD oNV+2JVuPESbl7wNbuTbn9XjY9VEGwBf76vIs0e4i73XuS+5HQhIOTXn3FfKvp5w04fEdWX7v2v zkO83WkTczQePMxtQD34ggqZujs8gUA8k+WDVV0ZUv0f+1xaHLa9jjoRPTH4xgSk6bbO+WW6494 hr3TI= X-Received: by 2002:a05:620a:4686:b0:8cf:d5ca:adde with SMTP id af79cd13be357-8d01c849700mr182385685a.8.1774610585538; Fri, 27 Mar 2026 04:23:05 -0700 (PDT) X-Received: by 2002:a05:620a:4686:b0:8cf:d5ca:adde with SMTP id af79cd13be357-8d01c849700mr182381085a.8.1774610585035; Fri, 27 Mar 2026 04:23:05 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66ad60361c6sm2214131a12.7.2026.03.27.04.23.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 04:23:04 -0700 (PDT) Message-ID: <4522e20c-70ab-48ef-8b0b-59f2548ebe64@oss.qualcomm.com> Date: Fri, 27 Mar 2026 12:23:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/16] drm/msm/a6xx: Fix gpu init from secure world To: Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-10-fc95b8d9c017@oss.qualcomm.com> <7d223573-438c-4e93-b4b4-64975c4da93f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7d223573-438c-4e93-b4b4-64975c4da93f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: txd-BbrMojgiuZ57XKsq149uJhZwbaQe X-Proofpoint-ORIG-GUID: txd-BbrMojgiuZ57XKsq149uJhZwbaQe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDA3OSBTYWx0ZWRfXxRbjJHSaqmt6 rUPixXRt85nidIvIJ0o6x/THcvrO7TiMegY/U/7h8KmJ+UK/89mza7Rf+67anIbnrtPeYvUSW1h yoM0aDQBvg0yEopBJxIM08X2YLVLaSrINaxfG2RIsLF3lJqVpGz5F3OG6imzQY6c6so8ixlAHJe rJAhudQnfqQy4ckegEsM/RQ2HNRig9Z6l2X2p27UC4KjyM8gh5KUkI/36HXpP7llBmfqrfFumse smlw4Mm6mLCSkkc/qDhW3E8yjijmhn9Us0nKsMX1PAJsrh1eOar1UngLgtnjXFF8W3nP1wECgEu 8DZKzf024Z/CjTYHEmEUmHaceDOPLNfmA+ulozdgFLsrLEdE5n+gJ307FekWyhFeiiEfcm7j3c+ fZmrz1xs+gAThhuXtutG9AGGBJtZgsYmwZE4evDL7x7w+ZzHvNvwCOdyi1rKWhOUoN1b4VsmPUT DQLme9Nb8WbX57CGBbA== X-Authority-Analysis: v=2.4 cv=ToXrRTXh c=1 sm=1 tr=0 ts=69c6689a cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=JAnykeg7oUmYEFbxpzMA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270079 On 3/26/26 9:12 PM, Akhil P Oommen wrote: > On 3/24/2026 3:37 PM, Konrad Dybcio wrote: >> On 3/23/26 9:12 PM, Akhil P Oommen wrote: >>> A7XX_GEN2 and newer GPUs requires initialization of few configurations >>> related to features/power from secure world. The SCM call to do this >>> should be triggered after GDSC and clocks are enabled. So, keep this >>> sequence to a6xx_gmu_resume instead of the probe. >>> >>> Fixes: 14b27d5df3ea ("drm/msm/a7xx: Initialize a750 "software fuse"") >>> Signed-off-by: Akhil P Oommen >>> --- >> >> This now makes this happen on *every GMU resume*, which sounds >> undesirable (kgsl does this in gen7_gmu_first_boot) > > I had this in my TODO list, but forgot to update. Will fix. > >> >> Similarly, we call a8xx_gpu_get_slice_info() on *every resume* > > No. We check then slice_mask and return early. Right, but we still branch into it I think the best solution would be to add something like gmu_first_boot_setup() which would be tracked by something like that bit you added in v2, where similar things could be moved That said, this is just an optimization Konrad