From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753921AbbINHpu (ORCPT ); Mon, 14 Sep 2015 03:45:50 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:49481 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbbINHpq (ORCPT ); Mon, 14 Sep 2015 03:45:46 -0400 From: Arnd Bergmann To: Fengguang Wu Cc: Yuantian Tang , Tejun Heo , "hdegoede@redhat.com" , "linux-ide@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH] ahci: qoriq: fixed using uninitialized variable warnings Date: Mon, 14 Sep 2015 09:45:33 +0200 Message-ID: <4524877.YJljz8o2LZ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150914065432.GA25168@wfg-t540p.sh.intel.com> References: <1441790182-20248-1-git-send-email-Yuantian.Tang@freescale.com> <20150914065432.GA25168@wfg-t540p.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:m/uwiFxoFOkXNyoUwOWefYtpTVjI66xJNiof2Hq2RYKTOltJNlN HaGAW7wxYvlbxBTyZI80GHdbHpq/hfdOWEQ4sDEOZHHVuQFyoTC1pYbVKclDT8vtrFr9ozO eLLCzrcEiZ9TtzAyLA+vfkTAWJg1YpxCZGdvDwlzRyUNKc1kZg15+qH+ubSTdJ99GnP7NKu BkprsL8/AQI3KwG9NKNDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:q/0dRP2z6i4=:Djvo6BRIDwV8xAl8Xk5QqD jNnUZGvQdmfu2LAQLO/FSKLYx/SGZ1wcWRVUVmbnetJ26QDYOwWQtY2vuyzj9CzVXQsWDTpFp kgnPD0LlxEciaggjJAYutBKeRmG+meOWqmK4jdc5a9kF8jek2oBvhqBB4bwgdErLSd8uHZD9P FT8YdyBuI2rtMXyMley5JA/fDsNzBxqQ0KAreq0NJDdj7LdYWy3JtOgXm5wg1e3tp4WP3khQX RLDnA4nWjLQocGSQ/pegLw8erGI1eU5/PfCusUeojE+XyRTdWQRCjNQHMS2Ui21KtJMrUxH7L W+VhDsjiTG6cqEsR7MeMMLYQ47X3iQW02Ppi4yUqGq/IunbphbmZWFUg6R7AEhlhoZdwuP1fb T10d2nKZr8hD0ricqmgkZqWgpV/6TxfZyfpUAUYl28pXs4V0S7WXyd2mTutZ6QELsKFI43cc6 zJ7Daii1XNChcHNilAwkQ9lxrmc+slw5nMEf7MjQHmLtbNN8qOs69funskokClC2zeNqkCl4b Wjlc4CRNzjrrFknygYw0N6C1Ht3eHRW6zMj/S600oA901SHkf9Vr8FfOS8+ftX75TDD3ZJ6Z4 Ggn9nxL0cfIsUDKbu4rB4PnWQrwfQa5q9VewzQWr6YSz4AStk9MGA2YyTo8BZ0q/SMZfZKxC3 SzWRqCXDTkYl2x9418gRRnCMg82DG8nywg0nmd7joTCTRg29W5Mqsavxx95mS+SywyM2f4GYX /+vw6ieZtBfKt2OZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 14 September 2015 14:54:32 Fengguang Wu wrote: > On Mon, Sep 14, 2015 at 06:51:36AM +0000, Yuantian Tang wrote: > > The ARCH should have been ARM for this driver. > > Do you think this warning would go away if adding a dependency on ARM? > > Yes, that may work. In general, we really want to leave drivers with a COMPILE_TEST dependency so they at least get cross-built on x86, ideally on all architectures. Does something like the below help? I think we really just need to help gcc a little to see the obvious. Arnd Signed-off-by: Arnd Bergmann diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c index e5e498812554..fc57208d8dcd 100644 --- a/drivers/ata/ahci_qoriq.c +++ b/drivers/ata/ahci_qoriq.c @@ -75,6 +75,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, u8 *d2h_fis = pp->rx_fis + RX_FIS_D2H_REG; struct ata_taskfile tf; bool online; + bool ls101021a_workaround = (qoriq_priv->type == AHCI_LS1021A); int rc; DPRINTK("ENTER\n"); @@ -92,7 +93,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, * After the sequence is complete, software should restore the * PxCMD and PxIS with the stored values. */ - if (qoriq_priv->type == AHCI_LS1021A) { + if (ls101021a_workaround) { px_cmd = readl(port_mmio + PORT_CMD); px_is = readl(port_mmio + PORT_IRQ_STAT); } @@ -106,7 +107,7 @@ static int ahci_qoriq_hardreset(struct ata_link *link, unsigned int *class, ahci_check_ready); /* restore the PxCMD and PxIS on ls1021 */ - if (qoriq_priv->type == AHCI_LS1021A) { + if (ls101021a_workaround) { px_val = readl(port_mmio + PORT_CMD); if (px_val != px_cmd) writel(px_cmd, port_mmio + PORT_CMD);