Hi, Here is a followup patch, which cleans up the check_partition() as well as some of the partition check routines. check_partition would now record the I/O error notice and proceed with the other partitions. The error will only be reported when all of the partitions have left the disk as "Unknown". Cleanup for partition checkers for ibm, atari and amiga. Comments ? Thanks Suzuki Erik Mouw wrote: > On Fri, Oct 06, 2006 at 10:43:42AM -0700, Suzuki K P wrote: > >>Erik Mouw wrote: >> >>>I think it's best not to change the current behaviour and let all >>>partition checkers run, even if one of them failed due to device >>>errors. I wouldn't mind if the behaviour changed like you propose, >>>though. >>> >> >>At present, the partition checkers doesn't run, if one of the preceeding >>checker has reported an error ! *But*, some of the checkers doesn't >>report the I/O error which they came across! So, this may let others >>run. Thats not we want, right. We would like them to return I/O errors, >>and and the check_partition should let other partition checkers continue. > > > Indeed, we want them to behave the same. I.e.: a partition checker > should tell when it encounters an I/O error. > > > Erik >