From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754272AbcHWQnY (ORCPT ); Tue, 23 Aug 2016 12:43:24 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33027 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753900AbcHWQnT (ORCPT ); Tue, 23 Aug 2016 12:43:19 -0400 Subject: Re: [PATCH] gpu: ipu-v3: fix a possible NULL dereference To: Sean Paul References: <1471354437-20971-1-git-send-email-clabbe.montjoie@gmail.com> Cc: p.zabel@pengutronix.de, Linux Kernel Mailing List , dri-devel From: Corentin LABBE Message-ID: <45288b3c-76a2-f9ae-67ae-7dd49785e75b@gmail.com> Date: Tue, 23 Aug 2016 18:23:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/08/2016 17:24, Sean Paul wrote: > On Tue, Aug 16, 2016 at 9:33 AM, LABBE Corentin > wrote: >> of_match_device could return NULL, and so cause a NULL pointer >> dereference later. >> >> For fixing this problem, we use of_device_get_match_data(), this will >> simplify the code a little by using a standard function for >> getting the match data. >> >> Signed-off-by: LABBE Corentin >> --- >> drivers/gpu/ipu-v3/ipu-common.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c >> index 99dcacf..05a9cc6 100644 >> --- a/drivers/gpu/ipu-v3/ipu-common.c >> +++ b/drivers/gpu/ipu-v3/ipu-common.c >> @@ -1207,15 +1207,13 @@ EXPORT_SYMBOL_GPL(ipu_dump); >> >> static int ipu_probe(struct platform_device *pdev) >> { >> - const struct of_device_id *of_id = >> - of_match_device(imx_ipu_dt_ids, &pdev->dev); >> struct ipu_soc *ipu; >> struct resource *res; >> unsigned long ipu_base; >> int i, ret, irq_sync, irq_err; >> const struct ipu_devtype *devtype; >> >> - devtype = of_id->data; >> + devtype = of_device_get_match_data(&pdev->dev); > > While you avoid the of_id dereference, it's possible that > of_device_get_match_data() returns NULL, so you're really just moving > the oops around. > > Sean > Hello I apologize for didnt seen that, I will send an updated patch which fix that. Regards