From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688AbdA3LE7 (ORCPT ); Mon, 30 Jan 2017 06:04:59 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:35900 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbdA3LEp (ORCPT ); Mon, 30 Jan 2017 06:04:45 -0500 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH] clockevents: Add a clkevt-of mechanism like clksrc-of From: Alexander Kochetkov In-Reply-To: <1485346876-28506-1-git-send-email-daniel.lezcano@linaro.org> Date: Mon, 30 Jan 2017 14:04:42 +0300 Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org Message-Id: <452A0749-9C76-4A55-81C0-FF426DD20A4B@gmail.com> References: <1485346876-28506-1-git-send-email-daniel.lezcano@linaro.org> To: Daniel Lezcano X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0UB54kq011720 > 25 янв. 2017 г., в 15:21, Daniel Lezcano написал(а): > > Hopefully, that can help to do some housework in the directory, perhaps > split the drivers in to entities, for example: > - clksrc-rockchip.c > - clkevt-rockchip.c > > Also, it gives the possibility to declare clocksources separately in the > DT and then use a clocksource from IP block while while clockevents are > used from another IP block. Hello, Daniel! There is no way to do declare clocksources and clockevents in the DT now. As I understood, it is incorrect to add properties like ‘clocksource’ or ‘clockevent’ to timer entries because this sounds like linux specific configuration. While device tree must contain only hardware description. Thus many timer drivers has implicit assumption: first DT timer became clocksource, second clockevent. If we can find the way to describe timer role in the DT, than many timer drivers could be rewritten such a way. Also, there is timers what use single IP to provide clocksource and clockevent at the same time. So splitting them into two files result into more complex code. Regards, Alexander.