From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
Jesper Juhl <jesper.juhl@gmail.com>
Subject: Re: [2.6.19 patch] ATA must depend on BLOCK
Date: Mon, 09 Oct 2006 15:08:37 +0200 [thread overview]
Message-ID: <452A49D5.4060904@s5r6.in-berlin.de> (raw)
In-Reply-To: <20061008231621.GM6755@stusta.de>
Adrian Bunk wrote:
> This patch fixes the following compile error with CONFIG_ATA=y,
> CONFIG_BLOCK=n:
[...]
> config ATA
> tristate "ATA device support"
> + depends on BLOCK
> depends on !(M32R || M68K) || BROKEN
> depends on !SUN4 || BROKEN
> select SCSI
The Kconfig isn't broken but the tool which generated the .config.
"config ATA\ select SCSI" implies a dependency of ATA on SCSI. SCSI
depends on BLOCK.
Therefore "select SCSI" && "config SCSI\ depends on BLOCK" implies
either "config ATA\ select BLOCK" or "config ATA\ depends on BLOCK".
{Ignore all what I said if ATA code directly uses the block API. Usages
of the block API to manipulate SCSI data structures, particularly the
request queue, does not necessarily count as independent usage of the
block API though.}
--
Stefan Richter
-=====-=-==- =-=- -=---
http://arcgraph.de/sr/
prev parent reply other threads:[~2006-10-09 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-08 23:16 Adrian Bunk
2006-10-09 13:08 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452A49D5.4060904@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=bunk@stusta.de \
--cc=dhowells@redhat.com \
--cc=jesper.juhl@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®