Re: [PATCH] firewire: handle sysfs errors

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Jeff Garzik wrote:
> Handle sysfs, driver core errors.
> 
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
> 
> ---
> 
>  drivers/ieee1394/nodemgr.c         |   36 ++++++++++++++++++++++++++++--------
> 
> diff --git a/drivers/ieee1394/nodemgr.c b/drivers/ieee1394/nodemgr.c
> index 8e7b83f..8628e3f 100644
> --- a/drivers/ieee1394/nodemgr.c
> +++ b/drivers/ieee1394/nodemgr.c
> @@ -414,9 +414,11 @@ static BUS_ATTR(destroy_node, S_IWUSR | 
>  
>  static ssize_t fw_set_rescan(struct bus_type *bus, const char *buf, size_t count)
>  {
> +	int rc;
> +
>  	if (simple_strtoul(buf, NULL, 10) == 1)
> -		bus_rescan_devices(&ieee1394_bus_type);
> -	return count;
> +		rc = bus_rescan_devices(&ieee1394_bus_type);
> +	return rc < 0 ? rc : count;
>  }

gcc 3.4.1-4mdk says:

drivers/ieee1394/nodemgr.c: In function `fw_set_rescan':
drivers/ieee1394/nodemgr.c:417: warning: 'rc' might be used
uninitialized in this function

The rest of the patch looks OK.

I get a lot more warn_unused_result warnings at other places in
ieee1394/nodemgr.c and ieee1394/hosts.c though. I could fix them all up
and fix this new warning in fw_set_rescan too if you don't mind...
-- 
Stefan Richter
-=====-=-==- =-=- -=-=-
http://arcgraph.de/sr/