From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Alex Dubov <oakad@yahoo.com>, Jeff Garzik <jgarzik@pobox.com>,
Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Fwd: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume
Date: Thu, 12 Oct 2006 07:54:58 +0200 [thread overview]
Message-ID: <452DD8B2.9040007@drzeus.cx> (raw)
In-Reply-To: <20061012020645.50871.qmail@web36715.mail.mud.yahoo.com>
Doesn't Jeff love me anymore? :(
Alex Dubov wrote:
> --- Jeff Garzik <jeff@garzik.org> wrote:
>
>
>> Date: Wed, 11 Oct 2006 17:48:09 -0400
>> From: Jeff Garzik <jeff@garzik.org>
>> To: oakad@yahoo.com, Andrew Morton <akpm@osdl.org>,
>> LKML <linux-kernel@vger.kernel.org>
>> Subject: [PATCH] drivers/{mmc,misc}: handle PCI errors on resume
>>
>>
>> Since pci_enable_device() is one of the first things called in the
>> resume step, take the minimalist approach and return immediately, if
>> pci_enable_device() fails during resume.
>>
>> Also, in sdhci: don't check for impossible condition (chip==NULL)
>>
>> Signed-off-by: Jeff Garzik <jeff@garzik.org>
>>
>>
I'm just being cautious. "This can't happen" is usually the last thing
you here before the end. ;)
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
OLPC, developer http://www.laptop.org
parent reply other threads:[~2006-10-12 5:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20061012020645.50871.qmail@web36715.mail.mud.yahoo.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452DD8B2.9040007@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oakad@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®