From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F2BC435526 for ; Mon, 10 Aug 2026 18:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385486; cv=none; b=oxKWxPdGjstArwN2kyNug+wk2zx6yWdwjFV2SMmo3ANIpwfV/Elyp+i5hCSQ2hYtiHHAjL/sqs9FUsbhGmfQH9cmyllqBtGyY4XR6tJCjLhhqLqVQM1yol+mtYcI0zciB+SWJYbOkNzA+2EjMWrf+tB+QABEm11taaNfZQEJT94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385486; c=relaxed/simple; bh=Z0855f1Ta+VEMIDJsjqYtSl5im3O4arPQPUi8a4259M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Byo2iynYkAfiqDhH+Y1F4S6NxKAGCLs6aBLx0S9E4MDSwmW3Gv17tU1vipl8kFjBuglY2uVkHc1p54KkQobzaxEWzr8oOgqxdemjoCLZfY/UQ2NVdueuMKoSnfLlYwJvPztgGLK5HeSAdM/NX9zX1okXTpUBDqb5h3wkphHbmUg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lZ/bKql9; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lZ/bKql9" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-383b4a3755fso2262709a91.3 for ; Mon, 10 Aug 2026 11:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786385483; x=1786990283; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z0Canle5rtkGjjXltqJt/4h8AMWrPL9Wd/WVDPCBLgc=; b=lZ/bKql9bWBDUr+qfJgnPvl/48GIicoEufrTZTn2qLoHJpXJMGSZnUo7T0QtkrquA3 ZhPO8RRpEAAYsKsEsTqB3mIO5nwwDtXjlllQr132Wvcbj2ax/pk4zwVErEBPvfoD2J1r WOXsvTgrhhaXxq7aq3w0uulubTXUIn2Tq78Jn3gpnQT0QJBEu3fDpzV5BOC/4pyXhso6 3d905T0ELs9wR1XDy1D/g9/I5kvNNbyqKHFGmnacFftaEJuXkv3BqU51DLdaFMR/l7Ft iFoW1GRjuy7s+QBiSSS3MkNkHhWkuJN1YovzqPM4CEY11fQGiKvfXXxPIkWveaxaYBdc M68w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385483; x=1786990283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=z0Canle5rtkGjjXltqJt/4h8AMWrPL9Wd/WVDPCBLgc=; b=mDhnUE+gv7xTQYDfDoRo+qLdvnLS3fkqMnw/DWEQ4iMJ7ruQXriuDCq24NCTD30HfN syqu71VG6eSgdWpOgLn7Q/3Xo90Pz7PLINVcemOFfsIjPw6fs9YNRDrzLNDrne9w7Ysy veXY5zn5ITmZ9ZTzXu2ia91IqNxzlESujdQY/WrUIAfXkkPx+3s5ORdv6Ew8Kutp9h+I cWAlsRLLjMf+N7sXb06KjRRm+HX9gfjw8CvS8rfHt303BhxM9MNGT9frxEU3shkY/osF xSpaxnRT5v9qoEPe7h9T6OIqq+rgKTgYcODtKu0I93XaLchlOOPkFj2wMToihJjkb+v9 aQ+Q== X-Forwarded-Encrypted: i=1; AHgh+Rpq9MkygeaKRHdXpfB210cuy6od9Ux1tSxxo307GirnQNjOxAB8v5B6FoZzMbSNcg2kjixdCmvahMk8Xpw=@vger.kernel.org X-Gm-Message-State: AOJu0YwYz487a7yto6bUrlQde386JNo4OJCkix5Nj9K40k60jzB7Fh+Y K5Dk/GPEC67U2ADc7YXl5k1oXHhiRKdXp05vL3kmMIK1wNcwjUZCrLt0 X-Gm-Gg: AR+sD12Ki0aKaUMvq7Pqdhk5qN8twytKvjBnyE2U+P9K29KECIRE+Bh5mQRxCZT0bpj uBhklvW1sOUKJItxeAWfYRlhtEzKHU40oMpIDphWt4C78jExgDp3eljRwfPtsGQ1fGlwk7IqB+5 kA74X2d0Pe0azq75Qiikx22lDZSQItVA/uUrB5awTdXI32KGvS+M3t5B+XMHK9Be3hzFjXocJLE WVGuGKQSrwNQ+y/SCELGAApBoImvtpRNQeWIi1kJA9DyoOaT8oQsl1pLgssqqrcPS8+fatsxhZo TtVD16plAcP31O+aokF4IJdkTfiO33QAi9GlKohhQu2bGeKIhYX6Xa62pvVjAjyqpiL88DT7ZsD lOV+jDsRY8lGV1Fkt5DiMsEn+jxCupvq7fBxJ+C69STgG9tP93UZp2FG13/Boq2SdfHM1ZeM/XQ IUPJcY9VdaU9mM1RAQShNjep5XRA3+PwLinH5hOf2VdihTxehSGDok9UJPY+NJ5Xs= X-Received: by 2002:a17:90b:3985:b0:38a:c3f:3b87 with SMTP id 98e67ed59e1d1-392620e6f9dmr23957113a91.12.1786385482746; Mon, 10 Aug 2026 11:11:22 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fa9:fa00:b1a9:6513:83c6:1d23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d53b873asm472795a91.17.2026.08.10.11.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:11:20 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Ludovic Desroches , linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 04/34] dmaengine: at_xdmac: move irq bottom half to dmaengine BH Date: Mon, 10 Aug 2026 11:09:05 -0700 Message-ID: <452a0aad787e4d64a057f13f47302782e9b3752e.1786384168.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-channel tasklet with the shared dmaengine BH helper. The handler continues to run in softirq context while dmaengine owns the common scheduling and teardown mechanism. Signed-off-by: Allen Pais --- drivers/dma/at_xdmac.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 901971e8bae6..5a970f9f3831 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -228,7 +228,6 @@ struct at_xdmac_chan { u32 save_cndc; u32 irq_status; unsigned long status; - struct tasklet_struct tasklet; struct dma_slave_config sconfig; spinlock_t lock; @@ -1759,9 +1758,9 @@ static void at_xdmac_handle_error(struct at_xdmac_chan *atchan) /* Then continue with usual descriptor management */ } -static void at_xdmac_tasklet(struct tasklet_struct *t) +static void at_xdmac_tasklet(struct dma_chan *chan) { - struct at_xdmac_chan *atchan = from_tasklet(atchan, t, tasklet); + struct at_xdmac_chan *atchan = to_at_xdmac_chan(chan); struct at_xdmac *atxdmac = to_at_xdmac(atchan->chan.device); struct at_xdmac_desc *desc; struct dma_async_tx_descriptor *txd; @@ -1865,7 +1864,7 @@ static irqreturn_t at_xdmac_interrupt(int irq, void *dev_id) if (atchan->irq_status & (AT_XDMAC_CIS_RBEIS | AT_XDMAC_CIS_WBEIS)) at_xdmac_write(atxdmac, AT_XDMAC_GD, atchan->mask); - tasklet_schedule(&atchan->tasklet); + dmaengine_schedule_bh(&atchan->chan); ret = IRQ_HANDLED; } @@ -2317,7 +2316,7 @@ static int at_xdmac_probe(struct platform_device *pdev) return PTR_ERR(atxdmac->clk); } - /* Do not use dev res to prevent races with tasklet */ + /* Do not use devm resources to prevent races with the BH worker */ ret = request_irq(atxdmac->irq, at_xdmac_interrupt, 0, "at_xdmac", atxdmac); if (ret) { dev_err(&pdev->dev, "can't request irq\n"); @@ -2397,7 +2396,7 @@ static int at_xdmac_probe(struct platform_device *pdev) spin_lock_init(&atchan->lock); INIT_LIST_HEAD(&atchan->xfers_list); INIT_LIST_HEAD(&atchan->free_descs_list); - tasklet_setup(&atchan->tasklet, at_xdmac_tasklet); + dmaengine_init_bh(&atchan->chan, at_xdmac_tasklet); /* Clear pending interrupts. */ while (at_xdmac_chan_read(atchan, AT_XDMAC_CIS)) @@ -2458,7 +2457,7 @@ static void at_xdmac_remove(struct platform_device *pdev) for (i = 0; i < atxdmac->dma.chancnt; i++) { struct at_xdmac_chan *atchan = &atxdmac->chan[i]; - tasklet_kill(&atchan->tasklet); + dmaengine_kill_bh(&atchan->chan); at_xdmac_free_chan_resources(&atchan->chan); } } -- 2.43.0