From: Hao Zhang <quic_hazha@quicinc.com>
To: Leo Yan <leo.yan@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Clark <james.clark@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Konrad Dybcio <konradybcio@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Jonathan Corbet <corbet@lwn.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
<coresight@lists.linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Jinlong Mao <quic_jinlmao@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Tao Zhang <quic_taozha@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
<linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
<linux-doc@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] dt-bindings: arm: Add Coresight Dummy Trace
Date: Wed, 10 May 2023 11:21:59 +0800 [thread overview]
Message-ID: <4535f993-156c-5401-53a8-bcf938bf24b7@quicinc.com> (raw)
In-Reply-To: <20230505120529.GB898031@leoy-yangtze.lan>
Hi Suzuki, Leo,
On 5/5/2023 8:05 PM, Leo Yan wrote:
> On Fri, May 05, 2023 at 11:54:03AM +0100, Suzuki Kuruppassery Poulose wrote:
>
> [...]
>
>>> +title: ARM Coresight Dummy component
>>> +
>>> +description: |
>>> + Coresight Dummy Trace Module is for the specific devices that kernel
>>> + don't have permission to access or configure, e.g., CoreSight TPDMs
>>> + on Qualcomm platforms. So there need driver to register dummy devices
>>> + as Coresight devices. It may also be used to define components that
>>> + may not have any programming interfaces (e.g, static links), so that
>>> + paths can be established in the driver. Provide Coresight API for
>>> + dummy device operations, such as enabling and disabling dummy devices.
>>> + Build the Coresight path for dummy sink or dummy source for debugging. > +
>>> + The primary use case of the coresight dummy is to build path in kernel
>>> + side for dummy sink and dummy source.
>>> +
>>> +maintainers:
>>> + - Mao Jinlong <quic_jinlmao@quicinc.com>
>>> + - Tao Zhang <quic_taozha@quicinc.com>
>>> + - Hao Zhang <quic_hazha@quicinc.com>
>>> + - Yuanfang Zhang <quic_yuanfang@quicinc.com>
>>
>> Given this is a generic "CoreSight" component, I would prefer to have the
>> CoreSight subsystem maintainers listed here (too). I don't mind
>> the entries above, but would like to make sure that the subsystem
>> people are aware of the changes happening here. Please use:
>>
>> Mike Leach <mike.leach@linaro.org>
>> Suzuki K Poulose <suzuki.poulose@arm.com>
>> Leo Yan <leo.yan@linaro.org>
> > Given I am spending little time on CoreSight reviewing, I'd like to
> use James Clark's email address to replace my own; I believe this
> would benefit long term maintenance.
>
> James Clark <james.clark@arm.com>
>
> Thanks!
>
Thanks for your review. I will update the maintainers in the next patch
series.
Thanks,
Hao
>> With the above:
>>
>> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>>
>>> +
>>> +properties:
>>> + compatible:
>>> + items:
>>> + - enum:
>>> + - arm,coresight-dummy-sink
>>> + - arm,coresight-dummy-source
>>> +
>>> + out-ports:
>>> + $ref: /schemas/graph.yaml#/properties/ports
>>> +
>>> + properties:
>>> + port:
>>> + description: Output connection from the source to Coresight
>>> + Trace bus.
>>> + $ref: /schemas/graph.yaml#/properties/port
>>> +
>>> + in-ports:
>>> + $ref: /schemas/graph.yaml#/properties/ports
>>> +
>>> + properties:
>>> + port:
>>> + description: Input connection from the Coresight Trace bus to
>>> + dummy sink, such as Embedded USB debugger(EUD).
>>> + $ref: /schemas/graph.yaml#/properties/port
>>> +
>>> +required:
>>> + - compatible
>>> +
>>> +if:
>>> + # If the compatible contains the below value
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: arm,coresight-dummy-sink
>>> +
>>> +then:
>>> + required:
>>> + - in-ports
>>> +
>>> +else:
>>> + required:
>>> + - out-ports
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + # Minimum dummy sink definition. Dummy sink connect to coresight replicator.
>>> + - |
>>> + sink {
>>> + compatible = "arm,coresight-dummy-sink";
>>> +
>>> + in-ports {
>>> + port {
>>> + eud_in_replicator_swao: endpoint {
>>> + remote-endpoint = <&replicator_swao_out_eud>;
>>> + };
>>> + };
>>> + };
>>> + };
>>> +
>>> + # Minimum dummy source definition. Dummy source connect to coresight funnel.
>>> + - |
>>> + source {
>>> + compatible = "arm,coresight-dummy-source";
>>> +
>>> + out-ports {
>>> + port {
>>> + dummy_riscv_out_funnel_swao: endpoint {
>>> + remote-endpoint = <&funnel_swao_in_dummy_riscv>;
>>> + };
>>> + };
>>> + };
>>> + };
>>> +
>>> +...
>>
next prev parent reply other threads:[~2023-05-10 3:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 9:24 [PATCH v4 0/3] Add support to configure Coresight Dummy subunit Hao Zhang
2023-05-05 9:24 ` [PATCH v4 1/3] Coresight: Add coresight dummy driver Hao Zhang
2023-05-05 9:57 ` Suzuki K Poulose
2023-05-10 2:56 ` Hao Zhang
2023-05-24 6:12 ` Hao Zhang
2023-05-05 9:24 ` [PATCH v4 2/3] dt-bindings: arm: Add Coresight Dummy Trace Hao Zhang
2023-05-05 10:54 ` Suzuki K Poulose
2023-05-05 12:05 ` Leo Yan
2023-05-10 3:21 ` Hao Zhang [this message]
2023-05-07 8:04 ` Krzysztof Kozlowski
2023-05-15 5:52 ` Hao Zhang
2023-06-08 16:09 ` Rob Herring
2023-05-05 9:24 ` [PATCH v4 3/3] Documentation: trace: Add documentation for " Hao Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4535f993-156c-5401-53a8-bcf938bf24b7@quicinc.com \
--to=quic_hazha@quicinc.com \
--cc=agross@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=corbet@lwn.net \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@arm.com \
--cc=konradybcio@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®