From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OOM killer meets userspace headers
Date: Thu, 19 Oct 2006 01:05:53 +1000 [thread overview]
Message-ID: <453642D1.1010302@yahoo.com.au> (raw)
In-Reply-To: <20061018145305.GA5345@martell.zuzino.mipt.ru>
Alexey Dobriyan wrote:
> Despite mm.h is not being exported header, it does contain one thing
> which is part of userspace ABI -- value disabling OOM killer. So,
> a) export mm.h to userspace
> b) got OOM_DISABLE disable define out of __KERNEL__ prison.
> c) turn bound values suitable for /proc/$PID/oom_adj into defines and export
> them too.
> d) put some headers into __KERNEL__ prison. It'd bizarre to include mm.h and
> get capability stuff.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
Seems fine. Silly question:
> +/* /proc/<pid>/oom_adj set to -17 protects from the oom-killer */
> +#define OOM_DISABLE (-17)
> +/* inclusive */
> +#define OOM_ADJUST_MIN (-16)
> +#define OOM_ADJUST_MAX 15
Why do you need the () for the -ves?
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2006-10-18 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 14:53 Alexey Dobriyan
2006-10-18 15:05 ` Nick Piggin [this message]
2006-10-18 18:46 ` Alexey Dobriyan
2006-10-18 19:12 ` Nick Piggin
2006-10-18 19:24 ` Alexey Dobriyan
2006-10-18 19:34 ` Nick Piggin
2006-10-18 15:08 ` David Woodhouse
2006-10-18 15:09 ` Christoph Hellwig
2006-10-18 18:21 ` [PATCH v2] " Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453642D1.1010302@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®