From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Al Viro <viro@ftp.linux.org.uk>,
Linus Torvalds <torvalds@osdl.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: dealing with excessive includes
Date: Fri, 20 Oct 2006 11:26:58 +0200 [thread overview]
Message-ID: <45389662.6010604@s5r6.in-berlin.de> (raw)
In-Reply-To: <20061019213545.bf5a51c1.rdunlap@xenotime.net>
Randy Dunlap wrote:
> Here's about half of checking includers of linux/smp_lock.h to see
> if they actually use any of its interfaces. (most don't)
>
> Yet to do: fs/* and arch/*
> Built only on x86_64.
[...]
> drivers/acpi/osl.c | 1 -
> drivers/block/acsi_slm.c | 1 -
> drivers/block/umem.c | 1 -
> drivers/char/ds1620.c | 1 -
> drivers/char/dsp56k.c | 1 -
> drivers/char/dtlk.c | 1 -
> drivers/char/ec3104_keyb.c | 1 -
> drivers/char/ftape/zftape/zftape-init.c | 1 -
> drivers/char/hangcheck-timer.c | 1 -
> drivers/char/ip27-rtc.c | 1 -
> drivers/char/lp.c | 1 -
> drivers/char/mem.c | 1 -
> drivers/char/mxser.c | 1 -
> drivers/char/ppdev.c | 1 -
> drivers/char/sysrq.c | 1 -
> drivers/char/vc_screen.c | 1 -
> drivers/char/watchdog/omap_wdt.c | 1 -
> drivers/char/watchdog/pcwd_usb.c | 1 -
> drivers/i2c/busses/scx200_acb.c | 1 -
> drivers/i2c/i2c-dev.c | 1 -
> drivers/ieee1394/raw1394.c | 1 -
> drivers/infiniband/ulp/iser/iser_verbs.c | 1 -
> drivers/input/evdev.c | 1 -
> drivers/input/input.c | 1 -
[... etc. pp. ...]
> sound/oss/swarm_cs4297a.c | 1 -
> sound/oss/trident.c | 1 -
> sound/oss/via82cxxx_audio.c | 1 -
> 166 files changed, 166 deletions(-)
[...]
I am afraid in many of these cases a proper cleanup would _replace_ the
include by the correct one, not just delete it. For example,
drivers/ieee1394/raw1394.c should include linux/spinlock.h. AFAICS it
does so at the moment only indirectly via another header.
--
Stefan Richter
-=====-=-==- =-=- =-=--
http://arcgraph.de/sr/
next prev parent reply other threads:[~2006-10-20 9:27 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 0:50 [RFC] typechecking for get_unaligned/put_unaligned Al Viro
2006-10-17 1:50 ` Linus Torvalds
2006-10-17 4:37 ` Al Viro
2006-10-17 15:12 ` Bogus deps checking (was Re: [RFC] typechecking for get_unaligned/put_unaligned) Ray Lehtiniemi
2006-10-17 15:24 ` [RFC] typechecking for get_unaligned/put_unaligned Linus Torvalds
2006-10-18 4:40 ` dealing with excessive includes Al Viro
2006-10-18 9:19 ` Alexey Dobriyan
2006-10-18 9:31 ` Al Viro
2006-10-18 10:00 ` Alexey Dobriyan
2006-10-18 17:42 ` Al Viro
2006-10-18 21:48 ` Alexey Dobriyan
2006-10-18 15:04 ` Linus Torvalds
2006-10-18 15:13 ` Matthew Wilcox
2006-10-18 16:06 ` Al Viro
2006-10-18 16:32 ` Linus Torvalds
2006-10-18 17:44 ` Al Viro
2006-10-19 16:23 ` Al Viro
2006-10-19 18:24 ` Andreas Gruenbacher
2006-10-20 0:53 ` Al Viro
2006-10-20 0:57 ` Al Viro
2006-10-20 12:43 ` Matthew Wilcox
2006-10-20 0:58 ` Al Viro
2006-10-20 0:59 ` Al Viro
2006-10-20 1:02 ` Al Viro
2006-10-20 4:35 ` Randy Dunlap
2006-10-20 9:26 ` Stefan Richter [this message]
2006-10-20 16:13 ` Randy Dunlap
2006-10-20 17:51 ` Stefan Richter
2006-10-22 17:58 ` Geert Uytterhoeven
2006-10-22 22:59 ` Andi Kleen
2006-10-23 8:29 ` Geert Uytterhoeven
2006-10-23 16:09 ` Linus Torvalds
2006-10-23 16:13 ` Geert Uytterhoeven
2006-10-23 16:31 ` Linus Torvalds
2006-10-23 16:52 ` Geert Uytterhoeven
2006-10-23 17:05 ` Linus Torvalds
2006-10-23 0:31 ` Matthew Wilcox
2006-10-23 0:42 ` Andi Kleen
2006-10-23 1:08 ` Matthew Wilcox
2006-10-23 1:31 ` Andi Kleen
2006-10-23 1:36 ` Matthew Wilcox
2006-10-23 1:41 ` Andi Kleen
2006-10-23 8:34 ` Geert Uytterhoeven
2006-10-23 1:48 ` Randy Dunlap
2006-10-23 1:49 ` Nick Piggin
2006-10-23 6:34 ` Stefan Richter
2006-10-18 16:15 ` Jan Engelhardt
2006-10-18 16:21 ` Matthew Wilcox
2006-10-18 5:42 ` [RFC] typechecking for get_unaligned/put_unaligned Dave Jones
2006-10-18 6:05 ` Al Viro
2006-10-19 16:52 ` Denis Vlasenko
2006-10-19 16:58 ` Al Viro
2006-10-17 9:04 ` David Howells
2006-10-17 15:28 ` Linus Torvalds
2006-10-28 15:24 dealing with excessive includes Tim Schmielau
2006-10-30 10:45 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45389662.6010604@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=adobriyan@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®