From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B2AC2B9F4 for ; Mon, 14 Jun 2021 14:26:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38323611C0 for ; Mon, 14 Jun 2021 14:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234534AbhFNO2H (ORCPT ); Mon, 14 Jun 2021 10:28:07 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3237 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232809AbhFNO2G (ORCPT ); Mon, 14 Jun 2021 10:28:06 -0400 Received: from fraeml703-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4G3YV2003Vz6G7Mx; Mon, 14 Jun 2021 22:19:05 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml703-chm.china.huawei.com (10.206.15.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 14 Jun 2021 16:26:01 +0200 Received: from [10.47.95.26] (10.47.95.26) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 14 Jun 2021 15:26:01 +0100 Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options To: Robin Murphy , Lu Baolu , "joro@8bytes.org" , "will@kernel.org" , "dwmw2@infradead.org" CC: "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Linuxarm , "Leizhen (ThunderTown)" , "chenxiang (M)" References: <1623414043-40745-1-git-send-email-john.garry@huawei.com> <1623414043-40745-4-git-send-email-john.garry@huawei.com> <4f2cec34-bad9-e1bf-85c1-04d1a0c1aecf@linux.intel.com> <6055cd0d-a1d3-a73a-6831-3837021f3c9c@huawei.com> <0a04f964-80f4-7b2a-9740-eae4596e4e09@arm.com> From: John Garry Message-ID: <453a4606-099c-3d06-13fd-dc29c24230f5@huawei.com> Date: Mon, 14 Jun 2021 15:19:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <0a04f964-80f4-7b2a-9740-eae4596e4e09@arm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.47.95.26] X-ClientProxiedBy: lhreml725-chm.china.huawei.com (10.201.108.76) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/06/2021 15:11, Robin Murphy wrote: > On 2021-06-14 08:53, John Garry wrote: >> On 12/06/2021 03:22, Lu Baolu wrote: >>> On 2021/6/11 20:20, John Garry wrote: >>>> @@ -453,8 +452,7 @@ static int __init intel_iommu_setup(char *str) >>>>               pr_warn("intel_iommu=forcedac deprecated; use >>>> iommu.forcedac instead\n"); >>>>               iommu_dma_forcedac = true; >>>>           } else if (!strncmp(str, "strict", 6)) { >>>> -            pr_info("Disable batched IOTLB flush\n"); >>>> -            intel_iommu_strict = 1; >>>> +            iommu_set_dma_strict(true); >>> I would like to deprecate this command line and ask users to use >>> iommu.strict instead. >> ok, but then I should probably make the AMD driver also officially >> support this. > Oops, I should have documented that "iommu.strict" already applies to > x86 as well. The interaction with the driver-specific parameters is a > bit weird and unintuitive, but it was done knowingly. Let me quickly > spin a kernel-parameters.txt fix for that... So I already had a pending patch here for the same to be included in this series: https://github.com/hisilicon/kernel-dev/commit/2375a2d888d78de9eb7d91d6f2c5891395300a96 If you want to do it, then ok. I might have to reorder the series though... Thanks, John