From: "Martin J. Bligh" <mbligh@aracnet.com>
To: William Lee Irwin III <wli@holomorphy.com>, linux-kernel@vger.kernel.org
Subject: Re: asm-i386/numaq.h fixes
Date: Mon, 17 Feb 2003 09:01:25 -0800 [thread overview]
Message-ID: <4540000.1045501282@[10.10.2.4]> (raw)
In-Reply-To: <20030217075107.GA14324@holomorphy.com>
> As can be seen from:
>
> http://www-3.ibm.com/software/data/db2/benchmarks/050300.html
>
> MAX_NUMNODES is 16 on NUMA-Q, not 8.
Not unless we have NUM_CPUS > BITS_PER_LONG it's not. Please don't change that.
> Also, PHYSADDR_TO_NID() needs to parenthesize its argument.
Fair enough.
> -- wli
>
> ===== include/asm-i386/numaq.h 1.5 vs edited =====
> --- 1.5/include/asm-i386/numaq.h Tue Jan 7 03:11:19 2003
> +++ edited/include/asm-i386/numaq.h Sun Feb 16 23:47:34 2003
> @@ -37,8 +37,8 @@
> #define PAGES_PER_ELEMENT (16777216/256)
>
> #define pfn_to_pgdat(pfn) NODE_DATA(pfn_to_nid(pfn))
> -#define PHYSADDR_TO_NID(pa) pfn_to_nid(pa >> PAGE_SHIFT)
> -#define MAX_NUMNODES 8
> +#define PHYSADDR_TO_NID(pa) pfn_to_nid((pa) >> PAGE_SHIFT)
> +#define MAX_NUMNODES 16
> extern int pfn_to_nid(unsigned long);
> extern void get_memcfg_numaq(void);
> #define get_memcfg_numa() get_memcfg_numaq()
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
next prev parent reply other threads:[~2003-02-17 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-17 7:51 William Lee Irwin III
2003-02-17 17:01 ` Martin J. Bligh [this message]
2003-02-17 18:12 ` William Lee Irwin III
2003-02-20 15:45 ` cpu-2.5.62-1 (was Re: asm-i386/numaq.h fixes) William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='4540000.1045501282@[10.10.2.4]' \
--to=mbligh@aracnet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®