From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9708235B644 for ; Fri, 3 Jul 2026 07:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783062213; cv=none; b=VbDIkQvf4SxAXTzdOv7Id0nZtPxg6tKJjftLDKMAeqAJUczOB7dkWbSyo4Ojk7T3spt8E2cVpmEbtxDR0lFbWn9Gb/+J+uQ9vCfWpmZ5jsvkobclvU0JJi72cjUSJiyQSCKhcHO1AGFFD3gKMJ1QoH7nrjZDh3xFEB9beqXnmRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783062213; c=relaxed/simple; bh=RPtED5zfqWi/w9WwjIlrZ18aD5j4qypewMoT7I4C6+g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qu09/4Y7wPNtK7jcCNcHPi4XtgcK48h/yXoUD/uggj3ZiS9qnxfRpTciXE3Z6Sjm25Lyvgyt+hZGOGL/+pZO7uM6BQ0zHdAf5Ocb0E+nK8fEwlmtz87pCPVFX+7DrN0Vo0EtIzcyTsBQHqTLMgQrkvpGO12VWiY28rdsyGSdJx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WWd0i0kc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HSl1rmDa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WWd0i0kc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HSl1rmDa" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6635rl1X3108952 for ; Fri, 3 Jul 2026 07:03:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wkfKJwLnKe7l6BvxWFlusvv1HVqjZu8lHqA9bY//AHo=; b=WWd0i0kcRIEyUsuH fPgilMcZpwwOfIGNiDt87MQFpBKCEpo/lImkJM4J6gZPt0GlxSrVCrF7FkWnW9Pa Wt1FYhYNi2UklCr/Y8DFS6gXyG0tvKes9JX3ATrjOpsD+81N7YiRey8HokFutCfG yVMkaw3qgdx0KSS2sIZzyFHmD7TqPYhS1WNUpn5QOlEAu9GO5lj1AgrqL0KXOhRe r2y6YBnLKivfsb3D6qFac3xvH882B0oAyVmJDEueMWS5fyGOWl4XQ5xpaPlsRuBo jdhOm20hv4YUm2wLOYXbhWd4r3mzjSpOdgLBaBlYEcYaHXW/QewYS0yZBiry19RS 6/8KHQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f60ey9shh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 07:03:31 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c9667280edeso470054a12.2 for ; Fri, 03 Jul 2026 00:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783062210; x=1783667010; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wkfKJwLnKe7l6BvxWFlusvv1HVqjZu8lHqA9bY//AHo=; b=HSl1rmDal/pe950bxznrQS19qbzu9n8Wf4H0pCCR7gL4HJxpUNeWGzLmQiSQPX/bTU PWK9P3ARle4IkCl8S3FcMdzS6mRU6THKgxJJkm7fAAjEo7udhIHlb38eLkr1JCXGuZQr Aeg7Y4iw6ORPcNbKeqJpvrqUuANufuPoMmGoQ0jp+x57X6B3W5dHEEfmQy+3OE8pN4qw NAMuoBeKJT7AsWtXpZ6ymzJxJkbiFwjJuOg6e4r4edW+1LZUFKOVvW0yUMBHCETxHosA C65y2CHuvnlJ8lgjkGGItRC2qKpMb0tzv7JZSl+vQ4JkvWSmhmssSshIvuqxer2E09Qy R4mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783062210; x=1783667010; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wkfKJwLnKe7l6BvxWFlusvv1HVqjZu8lHqA9bY//AHo=; b=bK109yUfZTtclLjIw+uBE5N6JBlCDlWA5V3U/j8iF9jOfkhzNYVqe9q/Y2nBtjeT7T fdJTrc5cWtvakE0AVUvLum/u1+dPIZm7apRhez8HDfhCvjViPpoY2yBxdijJY8zIzHSG UdovgXkMaU9WarkacEl1BAYL2h6HRGnnnw24vHFopEglIvI5KlZAYyd/529QS4AU9+YP HLm2pA6KhDafJjC9KEqOhYYzVAZRyCisEE9ngbS1evQImXdIrV4OkXvd8lMfH3ncT+D0 gt5BWzS8EdZjFCIJin3QdNuVhWuBDMn24ZEqNzCNxPIkYjRoIv+EhRfedVgZnbkZSZuo Zq4Q== X-Forwarded-Encrypted: i=1; AFNElJ+6rjQzYb4Nhy0DntOLNCUkBDkGu7h7BJEN8sktBBJmaCqQQ6sKcqrX2XuAf9g8cCgdy8jgOko+pN2ryZc=@vger.kernel.org X-Gm-Message-State: AOJu0YyTdNxTQQIDb/kDEWvRwjU2AxX9hzZTz4xlitGaGNUrZ9ldftC/ QuQQj88j8kjthQzUXvYuCJHnKZgvZ/CiIvPljaArqYAPetrCujXWjPZ2r4PZvRDvJBFqUYWtajN 3eUTOqXUbq9zIewxFlPpDrGIzMEGH4O6HyphtMqxTOa7/wJNNLVtNMH8U95HRbTDuJ28= X-Gm-Gg: AfdE7ckPBD3KYZvlNjyBZyDKOIyvqLezkneF7RYvIhezilCV6VSpXg7Gg8lSbDOGHaL I5cZ9Qtcn/dVQPXm12NVoozYob6yyZIrvkZMflP5Zsy8/Z6xcxW7wmMU7jrqDjGwIseBkp2m7e+ B7M9MKWgRvqZwiwnjpzcPM8/uXwoniORlMXJ+eDr27bETrgD0GwbvQ5euZKHJ+AFX7SxIAUsG/T YPH6o4fw+SYnP2v4VzmvBhRglM4KXgUG2KvI/p4q5+a+/0tXpAbxLG/mNmKefL3ztPeM196+bo4 g0UxRx19PKvbVSritLwlweA6q//z8gb7540yb27MGeVsNO6nBqcFpuga0TyZfcbZiyzgdtmRxyF ijpHnmTgZzoSAUzS1Q33A/ELctQnOqf0WzqLP4mjh+JCTOk2yRe2abldyVWVsbwCuU7FtfVaK7B rI3dYCHqqC X-Received: by 2002:a05:6a21:4688:b0:3b4:7eb0:47a1 with SMTP id adf61e73a8af0-3bfed2721b3mr12363089637.19.1783062210554; Fri, 03 Jul 2026 00:03:30 -0700 (PDT) X-Received: by 2002:a05:6a21:4688:b0:3b4:7eb0:47a1 with SMTP id adf61e73a8af0-3bfed2721b3mr12363045637.19.1783062210031; Fri, 03 Jul 2026 00:03:30 -0700 (PDT) Received: from [10.133.33.211] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c9e8eb0ef50sm2384087a12.6.2026.07.03.00.03.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 00:03:29 -0700 (PDT) Message-ID: <454222c5-53e1-4be7-b925-8a9c2bd04fb3@oss.qualcomm.com> Date: Fri, 3 Jul 2026 15:03:25 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] wifi: ath12k: Flush the posted write after writing to PCIE_SOC_GLOBAL_RESET To: Manivannan Sadhasivam , jjohnson@kernel.org Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, mani@kernel.org, Alex Williamson References: <20260623141649.41087-1-manivannan.sadhasivam@oss.qualcomm.com> <20260623141649.41087-2-manivannan.sadhasivam@oss.qualcomm.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260623141649.41087-2-manivannan.sadhasivam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDA2NSBTYWx0ZWRfX881wMWTw/Ygb oTVY5UAK30N4+MxPpnglJZhTdSdBiaCImD3/SuTqvAQ4+qyFZnnwc1+UVn7YtBxdP8Tov1ZhHYX O2UFpTLLkcd7QWk5sM727NEXJAEBZBjBEFYFOwjM7vPk75y938+HT/ykDJvyHoq677romyrzZ5N twDrFGchuJL4Khrg99Napn+4XzSeGgzK7GT8c1QQtzLSdT3U2/YqBIye1UFqm6sxw3lTpxDTBie LLpIOKZChNmWQ9UPkleekxSW+nUD/3D1gAWK/xTR2vp8aCroSv6fLNeOvHFPsjuNpGJz660x+w1 RQEjBDcyLxWMw/A2OtXr8NzQpejU+MFGlWT3JPxKpMbDyXCqiKmafXrJF9uO0VKp3D4t39dgiMA i4dzxqFUcjMTGBNG40jiPCuRbnA5NGX/GCNacw7mF3QJ0ng9HiUiETyd2PUmsUxfv+T1bKWs5YK +NBrcW+viE+5Fk/wnZg== X-Proofpoint-GUID: O9QANaG-xF3fKGAQSKpuCxWytj5zaScc X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDA2NSBTYWx0ZWRfXxzN4jR9hNp5r GXTXvngxMfA6nj8aQBqAsyTkndCg2NdeVIhSXjFqgb0IhhrcKTSl6TC/Vdvv5qE1JLHHTmxxuSz sbM5jSN2JHHeOIcTlKCyvJXLH0S7Tdc= X-Authority-Analysis: v=2.4 cv=SPRykuvH c=1 sm=1 tr=0 ts=6a475ec3 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=r1p2_3pzAAAA:8 a=EUspDBNiAAAA:8 a=fjTVS2QutaehiSyZ5pEA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=r_pkcD-q9-ctt7trBg_g:22 X-Proofpoint-ORIG-GUID: O9QANaG-xF3fKGAQSKpuCxWytj5zaScc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_02,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030065 On 6/23/2026 10:16 PM, Manivannan Sadhasivam wrote: > ath12k_pci_soc_global_reset() tries to reset the device by writing to the > PCIE_SOC_GLOBAL_RESET register. But it doesn't do a read-back to ensure > that the write gets flushed to the device before the delay. > > This may lead to the delay on the host to be insufficient, if the posted > write doesn't reach the device before the delay. > > So add a read-back after writing to the PCIE_SOC_GLOBAL_RESET register and > before the delay. > > Compile tested only. > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Reported-by: Alex Williamson > Closes: https://lore.kernel.org/linux-pci/20260622160822.09350246@shazbot.org > Signed-off-by: Manivannan Sadhasivam Reviewed-by: Baochen Qiang