From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: "Michał Pecio" <michal.pecio@gmail.com>,
pawell@cadence.com, peter.chen@kernel.org
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, mathias.nyman@intel.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2] usb: xhci: fixes lost of data for xHCI Cadence Controllers
Date: Mon, 2 Sep 2024 11:39:30 +0300 [thread overview]
Message-ID: <45435906-0a30-4546-a7e3-20f1f7d50713@linux.intel.com> (raw)
In-Reply-To: <20240830174504.1282f7b4@foxbook>
On 30.8.2024 18.45, Michał Pecio wrote:
> Hi,
>
>> Field Rsvd0 is reserved field, so patch should not have impact for
>> other xHCI controllers.
> Wait, is this a case of Linux failing to zero-initialize something that
> should be zero initialized before use (why not explain it as such?), or
> are you suggesting monkeying with internal xHC data at run time, in area
> which is known to actually be used by at least one implementation?
>
Patch is monkeying with internal xHC RsvdO field.
> There is no mention of Rsvd0 in the xHCI spec, did you mean RsvdO?
>
> Reserved and Opaque,
> For exclusive use by the xHC.
> Software shall *not* write this, unless allowed by the vendor.
>
> Cadence isn't the only xHC vendor...
>
Makes sense, Pawel Laszczak, could you make this patch Cadence
specific.
Thanks
Mathias
next prev parent reply other threads:[~2024-09-02 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240821055828.78589-1-pawell@cadence.com>
2024-08-21 6:01 ` Pawel Laszczak
2024-08-30 13:53 ` Mathias Nyman
2024-08-30 15:45 ` Michał Pecio
2024-09-02 8:39 ` Mathias Nyman [this message]
2024-09-03 8:23 ` Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45435906-0a30-4546-a7e3-20f1f7d50713@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=michal.pecio@gmail.com \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®