From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753486AbdEQWp1 (ORCPT ); Wed, 17 May 2017 18:45:27 -0400 Received: from mga05.intel.com ([192.55.52.43]:34572 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751957AbdEQWpZ (ORCPT ); Wed, 17 May 2017 18:45:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,356,1491289200"; d="scan'208";a="1131620897" Subject: Re: [PATCH v6 3/5] test: add new driver_data load tester To: "Luis R. Rodriguez" , AKASHI Takahiro , "Luis R. Rodriguez" , gregkh@linuxfoundation.org, wagi@monom.org, dwmw2@infradead.org, rafal@milecki.pl, arend.vanspriel@broadcom.com, rjw@rjwysocki.net, atull@opensource.altera.com, moritz.fischer@ettus.com, pmladek@suse.com, johannes.berg@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, kvalo@codeaurora.org, luto@kernel.org, dhowells@redhat.com, pjones@redhat.com, linux-kernel@vger.kernel.org References: <20170330032514.17173-1-mcgrof@kernel.org> <20170330032514.17173-4-mcgrof@kernel.org> <20170411083248.GE15139@linaro.org> <20170428014535.GO28800@wotan.suse.de> <20170511104625.GF22134@linaro.org> <20170511171143.GV28800@wotan.suse.de> From: "Li, Yi" Message-ID: <4545ecbd-b030-a2c0-66f2-faf4116b04b6@linux.intel.com> Date: Wed, 17 May 2017 17:45:22 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170511171143.GV28800@wotan.suse.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi Luis On 5/11/2017 12:11 PM, Luis R. Rodriguez wrote: > On Thu, May 11, 2017 at 07:46:27PM +0900, AKASHI Takahiro wrote: >> Luis, >> >> On Fri, Apr 28, 2017 at 03:45:35AM +0200, Luis R. Rodriguez wrote: >>>>> +To test an async call one could do:: >>>>> + >>>>> + echo anything > /lib/firmware/test-driver_data.bin >>>> Your current shell script doesn't search for the firmware in >>>> /lib/firmware unless you explicitly specify $FWPATH. >>> This is true but that is the *test* shell script, and it purposely avoids the >>> existing firmware path to avoid overriding dummy test files on the production >>> path. So the above still stands as it is not using the test shell script >>> driver_data.sh. >>> >>> I'll add a note: >>> >>> """ >>> Note that driver_data.sh uses its own temporary custom path for creating and >>> looking for driver data files, it does this to not overwrite any production >>> files you might have which may share the same names used by the test shell >>> script driver_data.sh. If you are not using the driver_data.sh script your >>> default path will be used. >>> """ >> That looks fine, but I think we'd better change the line: >> >>>>> + echo anything > /lib/firmware/test-driver_data.bin >> since it is just incorrect as far as driver_data.sh goes. > But that is accurate, given the default file we search for on test_driver_data.c > is test-driver_data.bin. It also does not create a conflict to overwrite a file > used on driver_data.sh as driver_data.sh uses a custom path. I think the note > above on custom path is sufficient for the developer or user to be aware of > the fact the driver_data.sh does it own thing, and that the example is just a > manual test case. > What do you mean by that its incorrect ? I understand it now, but was on the same boat as Akashi. Renamed my 12MB test firmware binary to /lib/firmware/test-driver_data.bin, but driver_data.sh only read back 9 byes from the tmp "ABCD0123". :-) What's the proper way to test a real image in the driver_data.sh script, change config_set_name? Yi > > Luis >