From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751943AbcEKNNz (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 May 2016 09:13:55 -0400
Received: from mout.kundenserver.de ([212.227.126.187]:53955 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751481AbcEKNNx convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 May 2016 09:13:53 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>
Cc: Tejun Heo <tj@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: dwc: add DMADEVICES dependency
Date: Wed, 11 May 2016 15:13:22 +0200
Message-ID: <4546329.1O9421M58I@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <yw1xh9e4hhwb.fsf@unicorn.mansr.com>
References: <1462970683-451525-1-git-send-email-arnd@arndb.de> <yw1xh9e4hhwb.fsf@unicorn.mansr.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset="iso-8859-1"
X-Provags-ID: V03:K0:USXkJbOaDajtvXVSZWbtv5nXCEOPCjnu05Dt0AMZP+Z3YiZucfw
 06SoaMliNhHpVb0d6m0zoQRq68UHXqkSK0djGB+RTgDBA1qlpTvdYM+AHbSAN5USxWiR9V6
 UsfQysEsDQ+igaQYBAYDSbkP1TLwcdz4KnAgTCopmMvYTFH56EqJVFdPzXxAOPi/O7YD0To
 CMw5FkVGqTaiqeXkYe+XA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:RRiCczkXi5w=:O9nIV8aEjk9bkGCd16pjn4
 H3fX9u698ia8QBOmSsqSXcIKncY2T6H3xkM8OjREfwsmjqWhBkLtxzSbGhDWvrEBjyHa+a5lF
 C6FeJ7FYi4wyx9htm8HKGOOo8lXNJHG4x0ZO9G6DElV/qxS9YAoJwpdzRny3OHHTF/je+Q5q1
 jKdCGAuopCcBebU9fuKjH7PzwdE5b4lK5keQTMAfg1hXg7u+YN2ZyfclJre2ot+1NnchmxAGb
 TADChpxTol2BPMeLqlDJETUdFGQinF9eOS7pNNwJVzJRxMy7PWPJphC4Mwu2xtuJ6KxUWK87a
 pMSrlwwTl5p3F4ZzZ4bYvSm1HJTypVPlzO4JT6btT3tTARQx+/k9eDGNCpaXYW5H05XNZpTf4
 xjyjqCfne1pJ4mvs0idnEK2mYLdB3x+1ce3sAXahu/cehdlmWxzllpOsWFwfSC8z+Cx2TBhgo
 eq5rL2TK1i1gJdoP4RZYg+eYvm1KwwQCEVnnKWaUrbr5u12qWN4Y5Q8pTuKTaCSygudf16isY
 ERD8gQwc6LZ0bjndWTXxDNmWlPjRBWKVXDOOi3d3JMPc3eGxUWT2m2G5AfsLoVttxxt6Q1kdM
 wA744/SrzVXsO7+phwZX3Q/BUV2iH1zeUEKLmK/MluTdwsrFIvtIRTib0EbQaKKYMdqw1wWeS
 lANtOmTjs06A0NLflOL94R7EZcJTMKoryIL2p9oFFiN5/h6bsZHzAlu3/1r/ztNPfZItWi3Y0
 FWrsCknc398Xh3xN
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday 11 May 2016 13:57:08 Måns Rullgård wrote:
> > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> > index 41b0725e58ad..8f7a4a4d2566 100644
> > --- a/drivers/ata/Kconfig
> > +++ b/drivers/ata/Kconfig
> > @@ -322,7 +322,7 @@ config SATA_DWC
> >
> >  config SATA_DWC_OLD_DMA
> >       bool "Support old device trees"
> > -     depends on SATA_DWC
> > +     depends on SATA_DWC && DMADEVICES
> >       select DW_DMAC_CORE
> >       default y if 460EX
> >       help
> > -- 
> 
> Isn't the proper fix here to have DW_DMAC_CORE select DMADEVICES?

No, all dmaengine drivers depend on DMADEVICES, so that would
cause a circular dependency.

The normal behavior for DMA slave drivers is to use the generic
DMA API and have a dependency on DMADEVICES but not on a particular
DMA engine implementation. In this case, the driver uses an exported
interface of the dw_dma driver directly, so we also need to select
that one, but it doesn't mean we can skip the normal dependency.

	Arnd