From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbcANUcS (ORCPT ); Thu, 14 Jan 2016 15:32:18 -0500 Received: from outbound.smtp.vt.edu ([198.82.183.121]:41316 "EHLO omr2.cc.vt.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750964AbcANUcR (ORCPT ); Thu, 14 Jan 2016 15:32:17 -0500 X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6+dev To: nick Cc: Ashwin Chaugule , Jassi Brar , Linux Kernel Mailing List Subject: Re: [PATCH RESEND] maibox:Remove unused functions in the file pcc.c From: Valdis.Kletnieks@vt.edu In-Reply-To: <5697F683.7010606@gmail.com> References: <1452577283-30122-1-git-send-email-xerofoify@gmail.com> <30235.1452792738@turing-police.cc.vt.edu> <5697F683.7010606@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1452803530_2311P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Thu, 14 Jan 2016 15:32:10 -0500 Message-ID: <45470.1452803530@turing-police.cc.vt.edu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --==_Exmh_1452803530_2311P Content-Type: text/plain; charset=us-ascii On Thu, 14 Jan 2016 14:26:59 -0500, nick said: > > > On 2016-01-14 12:32 PM, Valdis.Kletnieks@vt.edu wrote: > >> Have you looked in - > >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/acpi/cppc_acpi.c > >> ? > > > > Of course he didn't. > > > Or maybe he did a allmodconfig build on x86_64 bit and either that file builds correctly on x86 with That doesn't excuse not doing a 'git grep pcc_mbox_request_channel' or a 'grep -r pcc_mbox_request_channel .', both of which would have find the caller. > the patch applied due to it never being use on x86 or Kconfig files incorrectly set for allmodconfig > builds on x86 for this file, or maybe my compiler is broken but I doubt that as it works for all other > build errors similar to this. Or you don't have the foggiest clue how Kconfig works, and don't understand why in a 'allmodconfig' this file is *NOT* built. Hint 1: grep cppc drivers/acpi/Makefile obj-$(CONFIG_ACPI_CPPC_LIB) += cppc_acpi.o Hint 2: In the Kconfig: config ACPI_CPPC_LIB bool depends on ACPI_PROCESSOR depends on !ACPI_CPU_FREQ_PSS config ACPI_PROCESSOR tristate "Processor" depends on X86 || IA64 || ARM64 select ACPI_PROCESSOR_IDLE if X86 || IA64 select ACPI_CPU_FREQ_PSS if X86 || IA64 It's left as an exercise for the reader to figure out what happens to ACPI_CPPC_LIB when 'make allmodconfig' sets ACPI_PROCESSOR=m --==_Exmh_1452803530_2311P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Exmh version 2.5 07/13/2001 iQIVAwUBVpgFygdmEQWDXROgAQK/kw/+JPf5Ib9luPdgUd33AwfFqj2vSeuox1eN cvmDTLXE8UccZXKQS5+8ZYdZbF/vIZ8K0PZ7Xl/vrRVxgPH5DB+rdoL0azD6uYoK I7sxQHB/eRoWWm74ylZaBO9ixzkppjbBppoHEOjfoqzNwRIXrh29pH+QxYZbjFcc uShC/3pStrWusrjiGb8I5n9SWcbPqs78bllY7VetVgLmNhtiMwcDMA4cG4otK1md 7fQMvN8SdBWUh31dv3rtiQarIOfFHN/4+p/h9aILcc6L4ufzQdcB8MKakp0+UI+3 nWzM8+tBdUO+qV4vnr4M0pHk8zv33fWOSyRmTLSCopOuDJEgEZV8EcLgurEf/1MJ gbQPxf+2nZvNYhn5IglH9JZv532AfGfTGwjgq41ejoTssSQc/aKhXoWQBAWVWZqR oWeY6jKpsAVfUQtxKAbkYw52bK7bzi3WCAMJarz9yqjoQ5wA+w0JIaPa3JbOBPMV B52JbicfpXFJdgSqFLUvFxPjXupVYGw5bMm3X/X1Im5hvN+Vzn0a8sL734jSEolL f+/VPcnES/KD3M025Lp9YNlIRe81JU/hCcevmt6Ewu7SrZjG1yvCk3Cw8NBZrJan +9UQtjeEvELh6QJYRIRtx43IF4nH2DDPUdwIsGwN+h8mBF86+cH/JPcMsuOyzqgY v2NZh/pMJPM= =WMyi -----END PGP SIGNATURE----- --==_Exmh_1452803530_2311P--