From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965256AbcAUMVs (ORCPT ); Thu, 21 Jan 2016 07:21:48 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:51207 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758886AbcAUMVp (ORCPT ); Thu, 21 Jan 2016 07:21:45 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Masahiro Yamada , Greg Kroah-Hartman , Linux Kernel Mailing List , Peter Hurley , linux-serial@vger.kernel.org, Rob Herring , Frank Rowand , Grant Likely , devicetree@vger.kernel.org Subject: Re: [PATCH] 8250: uniphier: allow modular build with 8250 console Date: Thu, 21 Jan 2016 13:21:08 +0100 Message-ID: <4548262.MV5j98YUVi@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <3965359.aMgb8o9MaG@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:kX/4+3MMvu4uKB0Nlu8cihdK0Vq1wqVybWFAVWBda6hhvmVQ/C6 m7kbEQmaOi2f7G1SUTMXeTvaRSXZCLUZ7abBw3zNk7Wg1IsoRFMg+jj45hHhFGoN/BzwhcS gq28Y+eYRaNTiPuD/L/myFfdO+/dD1ZSLL92Si2Es6MJVbyIszjwlfh1CZENTZ1cqw6J5ad bf1LhVPWaJXj/7e+GGo3A== X-UI-Out-Filterresults: notjunk:1;V01:K0:7tjF5QdbJSg=:10Nx3djK4XlGyxL1F4bXNT 7ki2u3AjSQk8C7cFJIVFa1CrbKtbeiBOKF4MEM+ln+ixE8obuJiZOm+Xltwfqhus4VO1XRR7u cOgLC7YqzlC19aCs0Ob/UJ8Mr1DK2UWKn9Lt3QXcLN/qokpWFoxOg2nQ5qb7hbF8zqcQr4ogT ZUGJzXRnw6KLuH0NDuxIUfRXgWVz4I3NAyOOe7BRNGsOyo708XhmnVsIVkR5+LBHUiS1U1Afu EKI0yjFGTIJcmPfA2eb9pTMt526oD7qgbo9UdGf5WsvlOhhpfBwic6vFxAKaI2wPllrWv14R1 WsliRv2lyEbJQ9s9eT8DXcPHuAHjxtSAk1LJc70pdmYXFkoWR70eC50UYLUcvU5m2m+kKXStV Od6y/kPrgcETLsWtWk5YNamuWi7x1jo4wtZbVs+yC1dtgRV57KMYA+rM/ZFBN2UprrLGWMz2B n+Dcwg8NRH9G1BRjBAPea21amG6k9TiduRAPVw7ju0d190EJrqXfuBj+omOn12huyhBu12YMl VeA/P+Ui51tcj/o+4vdxj9HpND9hX4qQAllM1oaczkWvRRAukjHMI7rAu9e9TokU+bpV+9CGr lrQBVWVAWbI0PrQh3d3xOn0AGyA6wlXw5McBkl2OHvN4TFeuQgFO9+KUlcMeYIu/3XPyk4SGS h3vL9Dp3CeFudNtNy4T9iBSDqxMltuoogSO3rU+snnyswQj37/MTsMPa2GL2c+f5mCYP0duGi Fgw1VKmfqZ0TSTcn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 21 January 2016 20:39:03 Masahiro Yamada wrote: > 2016-01-14 7:33 GMT+09:00 Arnd Bergmann : > > The recently added uniphier 8250 port driver supports early console > > probing, and it supports being built as a module, but the combination > > of the two fails to link: > > > > ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined! > > > > Given that earlycon support in a loadable module makes no sense, > > making that code conditional on 'MODULE' is a correct solution. > > > > Signed-off-by: Arnd Bergmann > > Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support") > > > > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c > > index bab6b3ae2540..1b7bd26555b7 100644 > > --- a/drivers/tty/serial/8250/8250_uniphier.c > > +++ b/drivers/tty/serial/8250/8250_uniphier.c > > @@ -35,7 +35,7 @@ struct uniphier8250_priv { > > spinlock_t atomic_write_lock; > > }; > > > > -#ifdef CONFIG_SERIAL_8250_CONSOLE > > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE) > > static int __init uniphier_early_console_setup(struct earlycon_device *device, > > const char *options) > > { > > > > > > > If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted, > this build error will be fixed as well. But I doubt it is accepted soon... > > So, I am OK with this workaround to fix "make allmodconfig". > > Acked-by: Masahiro Yamada > Good point. Adding the DT maintainers to Cc. Guys, any chance of you picking up Masahiro's patch for 4.5? It can't hurt to have both patches merged, so it would still be good to have mine in the serial driver fixes, but we can live with either of the two to fix the build. Arnd