Re: + revert-iscsi-build-failure-use-depends-instead-of.patch added to -mm tree

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Remove all (2) "select NET" instances from all kernel Kconfig files.  Use
> "depends on" for them instead.  As Roman Zippel commented, "please don't
> select NET, it's way too broad."
> 
> This affects all IEEE1394 drivers and some SCSI drivers.  Networking (NET)
> will have to be enabled before any IEEE1394 or a few SCSI drivers can be
> enabled.  In particular for SCSI, the QLogic ISP4xxx driver
> (SCSI_QLA_ISCSI) and any FiberChannel drivers are affected.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: James Bottomley <James.Bottomley@steeleye.com>
> Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Cc: Roman Zippel <zippel@linux-m68k.org>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
> 
>  drivers/ieee1394/Kconfig     |    5 ++++-
>  drivers/scsi/Kconfig         |   13 +++++++++----
>  drivers/scsi/qla4xxx/Kconfig |    8 ++++----
>  3 files changed, 17 insertions(+), 9 deletions(-)
[...]

I'm OK with that change. You could have submitted the IEEE 1394 part
separately though.

A comment on the patch description: Only the eth1394 driver and the
ieee1394 core driver depend directly on NET. (All other FireWire drivers
depend on ieee1394 of course.) ieee1394's dependency on NET is planned
to be removed by a minor change to its implementation but we don't have
a deadline for this, as usual...
-- 
Stefan Richter
-=====-=-==- =-== ---=-
http://arcgraph.de/sr/