mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chaitanya Vadrevu <chaitanya.vadrevu@emerson.com>
To: Pete Connor <pete.connor@pythcoiner.dev>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_ni: use kzalloc_obj() for allocation
Date: Tue, 17 Feb 2026 15:48:07 -0600	[thread overview]
Message-ID: <454a61d1-9269-49cc-aa59-0842acc32710@emerson.com> (raw)
In-Reply-To: <20260217031913.1166949-1-pete.connor@pythcoiner.dev>

> Replace kzalloc() with the preferred kzalloc_obj() helper
> to address a checkpatch warning.
> 
> Signed-off-by: Pete Connor <pete.connor@pythcoiner.dev>
> ---
>  drivers/tty/serial/8250/8250_ni.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_ni.c b/drivers/tty/serial/8250/8250_ni.c
> index cb5b42b3609c..3f3dac694e20 100644
> --- a/drivers/tty/serial/8250/8250_ni.c
> +++ b/drivers/tty/serial/8250/8250_ni.c
> @@ -285,7 +285,7 @@ static int ni16550_probe(struct platform_device *pdev)
>  	bool rs232_property;
>  	int ret;
>  
> -	uart = kzalloc(sizeof(*uart), GFP_KERNEL);
> +	uart = kzalloc_obj(*uart, GFP_KERNEL);

tty-next doesn't yet have the commit that defines kzalloc_obj so this
fails to build. Will have to wait until tty-next has kzalloc_obj.

>  	if (!uart)
>  		return -ENOMEM;

Regards,
Chaitanya


  reply	other threads:[~2026-02-17 22:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-17  3:19 Pete Connor
2026-02-17 21:48 ` Chaitanya Vadrevu [this message]
2026-03-12 13:44 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=454a61d1-9269-49cc-aa59-0842acc32710@emerson.com \
    --to=chaitanya.vadrevu@emerson.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=pete.connor@pythcoiner.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®