mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Heidelberg <david@ixit.cz>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>, clabbe@baylibre.com
Cc: gregkh@linuxfoundation.org, johan@kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	martin.blumenstingl@googlemail.com
Subject: Re: [PATCH v8 1/2] usb: serial: add support for CH348
Date: Mon, 31 Mar 2025 00:11:42 +0200	[thread overview]
Message-ID: <454deee5-5359-4fc8-bdaa-801de90f6257@ixit.cz> (raw)
In-Reply-To: <20250330012451.13711-1-frattaroli.nicolas@gmail.com>

If another Tested-by is needed to get this in, I can build kernel w/ 
driver and give it shot too.

Thanks for your work & testing!

On 30/03/2025 03:24, Nicolas Frattaroli wrote:
> On Tue, 4 Feb 2025 13:58:40 +0000 Corentin Labbe wrote:
>> The CH348 is an USB octo port serial adapter.
>> The device multiplexes all 8 ports in the same pair of Bulk endpoints.
>> Since there is no public datasheet, unfortunately it remains some magic
>> values
>>
>> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
>> ---
>>   drivers/usb/serial/Kconfig  |   9 +
>>   drivers/usb/serial/Makefile |   1 +
>>   drivers/usb/serial/ch348.c  | 736 ++++++++++++++++++++++++++++++++++++
>>   3 files changed, 746 insertions(+)
>>   create mode 100644 drivers/usb/serial/ch348.c
>>
> 
> Tested-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> 
> Quickly gave this another test by just connecting two ports of a CH348 device
> together and making sure data arrives unchowdered at the other end when sending
> at full speed with various baud rates. Seems to work about as well as I
> expected my jumper wires to hold up at higher baudrates.
> 
> I'll likely use this to lessen the pile of active USB-to-serial devices on my
> desk while working, so many thanks for keeping up the good work on the driver.
> That way it'll also get some more in-depth real world testing in th e coming
> weeks, but I doubt it needs more testing at this stage.
> 
> Regards,
> Nicolas Frattaroli

-- 
David Heidelberg


  reply	other threads:[~2025-03-30 22:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-04 13:58 [PATCH v8 0/2] " Corentin Labbe
2025-02-04 13:58 ` [PATCH v8 1/2] " Corentin Labbe
2025-03-20 12:56   ` David Heidelberg
2025-05-12 10:03   ` Johan Hovold
2025-07-15 21:20     ` Martin Blumenstingl
2025-07-16  7:44       ` Greg KH
2025-07-16  8:28         ` Martin Blumenstingl
2025-07-16  8:57           ` Greg KH
2025-07-16  9:31             ` Martin Blumenstingl
2025-07-16 10:00               ` Greg KH
2025-07-16 11:24                 ` Martin Blumenstingl
2025-07-25 10:14               ` Johan Hovold
2025-07-25 10:07       ` Johan Hovold
2025-07-26 14:54         ` Martin Blumenstingl
2025-07-29  9:43           ` Johan Hovold
2025-07-29 20:45             ` Martin Blumenstingl
2025-08-04 12:32               ` Johan Hovold
2025-08-04 21:35                 ` Martin Blumenstingl
2025-08-27 10:07                   ` Johan Hovold
2025-11-29 15:59                     ` Martin Blumenstingl
2025-12-01 14:10                       ` Johan Hovold
2025-12-15  2:10                         ` Martin Blumenstingl
2026-01-13 15:31                           ` Johan Hovold
2026-04-22 12:55                             ` David Heidelberg
2025-02-04 13:58 ` [PATCH v8 2/2] usb: serial: add Martin and myself as maintainers of CH348 Corentin Labbe
2025-03-30  1:24 ` [PATCH v8 1/2] usb: serial: add support for CH348 Nicolas Frattaroli
2025-03-30 22:11   ` David Heidelberg [this message]
     [not found] ` <CA+j61XMwrtRJhGiJu_T5tt3g14fseOqvOJZLbb2bQGduSJsmxQ@mail.gmail.com>
2025-05-04 21:26   ` [PATCH v8 0/2] " Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=454deee5-5359-4fc8-bdaa-801de90f6257@ixit.cz \
    --to=david@ixit.cz \
    --cc=clabbe@baylibre.com \
    --cc=frattaroli.nicolas@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®