From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C411C5519F for ; Tue, 17 Nov 2020 11:12:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A07520870 for ; Tue, 17 Nov 2020 11:12:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728450AbgKQLMN (ORCPT ); Tue, 17 Nov 2020 06:12:13 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:7635 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727390AbgKQLMM (ORCPT ); Tue, 17 Nov 2020 06:12:12 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Cb3DT4FWBz15LjT; Tue, 17 Nov 2020 19:11:53 +0800 (CST) Received: from [10.174.178.174] (10.174.178.174) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Tue, 17 Nov 2020 19:11:29 +0800 Subject: Re: [PATCH] iommu: fix return error code in iommu_probe_device() To: Lu Baolu , , References: <20201117025238.3425422-1-yangyingliang@huawei.com> <835ab066-b6b8-a211-4941-c01781031de8@linux.intel.com> From: Yang Yingliang Message-ID: <454f5e3e-c380-e8a5-9283-3f7578eb601e@huawei.com> Date: Tue, 17 Nov 2020 19:11:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <835ab066-b6b8-a211-4941-c01781031de8@linux.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.178.174] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/11/17 17:40, Lu Baolu wrote: > Hi Yingliang, > > On 2020/11/17 10:52, Yang Yingliang wrote: >> If iommu_group_get() failed, it need return error code >> in iommu_probe_device(). >> >> Fixes: cf193888bfbd ("iommu: Move new probe_device path...") >> Reported-by: Hulk Robot >> Signed-off-by: Yang Yingliang >> --- >>   drivers/iommu/iommu.c | 4 +++- >>   1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c >> index b53446bb8c6b..6f4a32df90f6 100644 >> --- a/drivers/iommu/iommu.c >> +++ b/drivers/iommu/iommu.c >> @@ -253,8 +253,10 @@ int iommu_probe_device(struct device *dev) >>           goto err_out; >>         group = iommu_group_get(dev); >> -    if (!group) >> +    if (!group) { >> +        ret = -ENODEV; > > Can you please explain why you use -ENODEV here? Before 79659190ee97 ("iommu: Don't take group reference in iommu_alloc_default_domain()"), in iommu_alloc_default_domain(), if group is NULL, it will return -ENODEV. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/iommu/iommu.c?h=v5.10-rc4&id=70b8170e55d3ca9503a53211967faee6b5f18b19 > > Best regards, > baolu > >>           goto err_release; >> +    } >>         /* >>        * Try to allocate a default domain - needs support from the >> > .