mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "longwei (I)" <longwei27@huawei.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: <pasha.tatashin@soleen.com>, <pratyush@kernel.org>,
	<akpm@linux-foundation.org>, <graf@amazon.com>,
	<leitao@debian.org>, <corbet@lwn.net>, <rdunlap@infradead.org>,
	<linux-mm@kvack.org>, <kexec@lists.infradead.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<hewenliang4@huawei.com>
Subject: Re: [PATCH v2 0/2] kho: drop the incoming sub-blob debugfs view
Date: Thu, 19 Nov 2026 17:11:37 +0800	[thread overview]
Message-ID: <4550c77f-aecd-4d6a-963f-fdaa2c243100@huawei.com> (raw)
In-Reply-To: <179507678647.425130.13205346175314463200.b4-review@b4>

Hi Mike,

Thanks for the detailed explanation! I now understand why c609c144b0e8
is not the right Fixes target — the pages weren't freed back then, so
there was no UAF. The kho_restore_free() path in d376e4b55c9a0 is what
actually made it reachable.

I will send v3 with the following changes:

- Fold patch 2 (documentation removal) into patch 1, so stable
  backports pick up both code and docs together
- Update Fixes tag to d376e4b55c9a0 ("liveupdate: centralize state
  management into struct luo_ser")

Best,
Long Wei

在 2026/11/19 16:26, Mike Rapoport 写道:
> Hi,
> 
> Please don't send vN+1 as a reply to vN.
> 
>> kho/in/sub_fdts exposes the raw contents of the sub-blobs described by
>> the incoming KHO FDT.  KHO does not own those pages: they belong to the
>> producers' consumers and have independent lifetimes.  LUO, for example,
>> restores and frees its state in early_initcall, before kho_init()
>> (fs_initcall) creates the debugfs view, so the blobs point at pages that
>> are already back in the buddy allocator.  Reading them triggers a KASAN
>> use-after-free in _copy_to_user().
>>
>> The same information is already available to user space from in/fdt,
>> which KHO does own and which stays reserved.  Drop the directory rather
>> than adding another interface to describe it, keeping the -rc fix small.
>>
>> Patch 1 removes the interface, patch 2 drops its documentation.
> 
> Patch 2 is only four lines of documentation for the interface patch 1
> removes. It could be folded into patch 1 so that a stable backport
> removes the documentation together with the code.
> 


      reply	other threads:[~2026-11-19  9:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:29 [PATCH 0/2] kho: expose incoming sub-blob metadata instead of contents Long Wei
2026-11-17  9:29 ` [PATCH 1/2] " Long Wei
2026-11-18 16:38   ` Pasha Tatashin
2026-11-17  9:29 ` [PATCH 2/2] docs: kho: describe the in/blobs debugfs file Long Wei
2026-11-19  6:37 ` [PATCH v2 0/2] kho: drop the incoming sub-blob debugfs view Long Wei
2026-11-19  6:37   ` [PATCH v2 1/2] kho: do not expose incoming sub-blob contents in debugfs Long Wei
2026-11-19  8:26     ` Mike Rapoport
2026-11-19  6:38   ` [PATCH v2 2/2] docs: kho: drop kho/in/sub_fdts description Long Wei
2026-11-19  6:53   ` [PATCH v2 0/2] kho: drop the incoming sub-blob debugfs view Pasha Tatashin
2026-11-19  8:26   ` Mike Rapoport
2026-11-19  9:11     ` longwei (I) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4550c77f-aecd-4d6a-963f-fdaa2c243100@huawei.com \
    --to=longwei27@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=graf@amazon.com \
    --cc=hewenliang4@huawei.com \
    --cc=kexec@lists.infradead.org \
    --cc=leitao@debian.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=pratyush@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rppt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®