From: Caleb Connolly <caleb@connolly.tech>
To: Satya Priya <quic_c_skakit@quicinc.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Douglas Anderson <dianders@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Andy Gross <agross@kernel.org>,
mka@chromium.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_tdas@quicinc.com,
linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: lpass: Fix the invalid index errors seen at bootup
Date: Tue, 23 Aug 2022 15:26:16 +0000 [thread overview]
Message-ID: <4551f8f0-9cf7-3a45-5eb3-e64066fdf00c@connolly.tech> (raw)
In-Reply-To: <1661245527-5596-1-git-send-email-quic_c_skakit@quicinc.com>
Could you adjust the subject line to reflect which CC this patch is for?
clk: qcom: lpassaudiocc-sc7280: Fix the invalid index errors seen at bootup
This matches other commits in the subsystem.
On 23/08/2022 10:05, Satya Priya wrote:
> After support for resets is added, qcom_cc_really_probe()
> would be called twice for the same cc which causes
> invalid index errors in qcom_clk_hw_get().
>
> qcom_cc_clk_hw_get: invalid index 5
> qcom_cc_clk_hw_get: invalid index 6
> qcom_cc_clk_hw_get: invalid index 7
>
> Fixes: a9dd26639d05 ("clk: qcom: lpass: Add support for LPASS clock controller for SC7280")
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
> ---
> This patch depends on [1]
> [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=667984
>
> drivers/clk/qcom/lpassaudiocc-sc7280.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> index 063e036..5d4bc56 100644
> --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c
> +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> @@ -785,7 +785,7 @@ static int lpass_audio_cc_sc7280_probe(struct platform_device *pdev)
> regmap_write(regmap, 0x4, 0x3b);
> regmap_write(regmap, 0x8, 0xff05);
>
> - ret = qcom_cc_really_probe(pdev, &lpass_audio_cc_sc7280_desc, regmap);
> + ret = qcom_cc_probe_by_index(pdev, 0, &lpass_audio_cc_sc7280_desc);
> if (ret) {
> dev_err(&pdev->dev, "Failed to register LPASS AUDIO CC clocks\n");
> pm_runtime_disable(&pdev->dev);
> --
> 2.7.4
>
--
Kind Regards,
Caleb
next prev parent reply other threads:[~2022-08-23 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 9:05 Satya Priya
2022-08-23 15:26 ` Caleb Connolly [this message]
2022-08-23 15:37 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4551f8f0-9cf7-3a45-5eb3-e64066fdf00c@connolly.tech \
--to=caleb@connolly.tech \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=quic_c_skakit@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®